-
Notifications
You must be signed in to change notification settings - Fork 42
fix: expose tree item decoration lane #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: expose tree item decoration lane #549
Conversation
a0d19f6 to
2b89f7f
Compare
3613c91 to
3f4537b
Compare
3f4537b to
6cfe7fb
Compare
|
Hello, I wanted to check if this or a similar fix can be accepted. Thanks for your time |
|
Hi! Originally, I planned for the new tree component to be as simple as possible. There are so many variations of it in VSCode that I’m not even sure it can be unified at all. In the previous version, I tried to standardize it based on the Timeline and Explorer widgets, but the API ended up being overly complicated and not flexible enough. That’s why, in the new version, I decided to leave the implementation of the content, text formatting, and interactions up to the user. On the other hand, your pull request reflects the VSCode Tree API, so it does make sense in that regard. However, I haven’t had time for weeks to review it thoroughly and with a clear head. And I don’t want to merge any changes until I fully understand how it works. |
Hi, thanks for the reply. I totally understand your point about keeping the tree simple. If there’s anything I can do to make it easier for you to review it, like moving styles to the example or splitting the change into smaller parts, please let me know. You should also have write access if you want to adjust the PR directly. If it takes more time on your side, I can always fork the repo and keep working there. |
bendera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left few comments.
|
Btw., I haven't mentioned it but great job and thanks for the effort you put in! |
Great review, thanks for the links. I learned a lot. Since the last round, I also adjusted the icon container. I wanted to support Please take a look and check out the updated Problems view demo. Thanks for your time |
Closes: vscode-elements#548 Signed-off-by: dankeboy36 <[email protected]>
Signed-off-by: dankeboy36 <[email protected]>
e4d2aa4 to
f631698
Compare












Closes: #548
scm-tree.mov
problems-tree.mov
labelanddescriptionto match the VS Code TreeItem API.actionsslot after<vscode-collapsible>for consistency.<vscode-toolbar-button>implementations independent from the tree, but included an example to show that integration is possible. The demo now mirrors the SCM view, including actions, decorators, descriptions, and text overflow handling.<vscode-icon>withaction-iconto produce nicer hover UX. The tree can still handle oversized icons.