feat: basic rating display #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Guilera
force-pushed
the
feat/basic-rating-display
branch
from
f86198c to
1d12420
Compare
lucasfp13
approved these changes
Feb 6, 2025
packages/components/src/molecules/ProductCard/ProductCardContent.tsx
Outdated
Show resolved
Hide resolved
Guilera
force-pushed
the
feat/basic-rating-display
branch
3 times, most recently
from
160d8be to
e59b001
Compare
Guilera
changed the base branch from
feat/reviews-and-ratings
to
feat/rating-resolvers
Base automatically changed from
feat/rating-resolvers
to
feat/reviews-and-ratings
February 14, 2025 13:26
Guilera
force-pushed
the
feat/basic-rating-display
branch
from
e59b001 to
6cc5ce0
Compare
![semgrep-code-vtex-org[bot]](https://avatars.githubusercontent.com/u/1288938?s=60&v=4){kind=small}
Guilera
force-pushed
the
feat/reviews-and-ratings
branch
from
d57303d to
2203c7f
Compare
Guilera
force-pushed
the
feat/reviews-and-ratings
branch
from
9c2cebb to
736e0f8
Compare
Guilera
force-pushed
the
feat/basic-rating-display
branch
from
6cc5ce0 to
657ed77
Compare
Guilera
force-pushed
the
feat/basic-rating-display
branch
from
657ed77 to
e30894a
Compare
pedromtec
reviewed
Feb 19, 2025
packages/components/src/molecules/ProductCard/ProductCardContent.tsx
Outdated
Show resolved
Hide resolved
pedromtec
reviewed
Feb 19, 2025
packages/components/src/molecules/ProductTitle/ProductTitle.tsx
Outdated
Show resolved
Hide resolved
pedromtec
reviewed
Feb 19, 2025
packages/components/src/molecules/ProductTitle/ProductTitle.tsx
Outdated
Show resolved
Hide resolved
pedromtec
approved these changes
Feb 19, 2025
Guilera
force-pushed
the
feat/basic-rating-display
branch
from
e30894a to
bfffb66
Compare
Guilera
added a commit
that referenced
this pull request
Feb 19, 2025
## What's the purpose of this pull request? To add rating stars to existing components: - `<ProductCardContent/>` - `<ProductTitle/>` ## How it works? If the feature flag for reviews and ratings, defined at `discovery.config`, it's turned on, then everywhere a `<ProductCard/>` is used then it will display the product star rating ## How to test it? [preview](https://starter-git-feat-basic-rating-display-vtex.vercel.app/) ## References [JIRA TASK: SFS-2063](https://vtex-dev.atlassian.net/browse/SFS-2063) [JIRA TASK: SFS-2065](https://vtex-dev.atlassian.net/browse/SFS-2065)     ## Checklist <em>You may erase this after checking them all 😉</em> **PR Description** - [ ] Displays rating at `Just Arrived` - [ ] Displays rating at `Most Wanted` - [ ] Displays rating at `Deals & Promotions` - [ ] Displays rating at `Product Details` - [ ] Displays rating at `Product Gallery`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
To add rating stars to existing components:
<ProductCardContent/><ProductTitle/>How it works?
If the feature flag for reviews and ratings, defined at
discovery.config, it's turned on, then everywhere a<ProductCard/>is used then it will display the product star ratingHow to test it?
preview
References
JIRA TASK: SFS-2063
JIRA TASK: SFS-2065
Checklist
You may erase this after checking them all 😉
PR Description
Just ArrivedMost WantedDeals & PromotionsProduct DetailsProduct Gallery