fix(escapeHtmlComment): Avoid throwing errors due to src not being a …

[lazytong-tech]

When building my project, Vue threw the error src. replace is not a function. After adding toString() to the function escapeHtmlComment, this error did not occur again

[skirtles-code]

Are you able to provide a reproduction of the problem?

I don't think this can be merged until we understand the underlying reason why a non-string was passed to this function.

It reminds me of #8870, which turned out to be caused by UnoCSS incorrectly rewriting Vue code.

[lazytong-tech]

When I use the nuxt3 framework and webpack5 as a builder, using unplugin-auto import/webpack and unplugin-vue components/webpack will result in a TypeError: src. replace is not a function error during server-side rendering.
Here is the error message:

$ node .output/server/index.mjs
Listening on http://[::]:3000
[nitro] [unhandledRejection] TypeError: src.replace is not a function
    at Object.escapeHtmlComment (/workspace/house/.output/server/node_modules/@vue/shared/dist/shared.cjs.prod.js:424:29)
    at renderVNode (/workspace/house/.output/server/node_modules/@vue/server-renderer/dist/server-renderer.cjs.prod.js:484:34)
    at renderComponentSubTree (/workspace/house/.output/server/node_modules/@vue/server-renderer/dist/server-renderer.cjs.prod.js:459:7)
    at renderComponentVNode (/workspace/house/.output/server/node_modules/@vue/server-renderer/dist/server-renderer.cjs.prod.js:394:12)
    at renderVNode (/workspace/house/.output/server/node_modules/@vue/server-renderer/dist/server-renderer.cjs.prod.js:507:14)
    at renderVNodeChildren (/workspace/house/.output/server/node_modules/@vue/server-renderer/dist/server-renderer.cjs.prod.js:523:5)
    at renderElementVNode (/workspace/house/.output/server/node_modules/@vue/server-renderer/dist/server-renderer.cjs.prod.js:567:9)
    at renderVNode (/workspace/house/.output/server/node_modules/@vue/server-renderer/dist/server-renderer.cjs.prod.js:505:9)
    at renderComponentSubTree (/workspace/house/.output/server/node_modules/@vue/server-renderer/dist/server-renderer.cjs.prod.js:459:7)
    at renderComponentVNode (/workspace/house/.output/server/node_modules/@vue/server-renderer/dist/server-renderer.cjs.prod.js:394:12)

After changing

function escapeHtmlComment(src) {
  return src.replace(commentStripRE, "");
}

in @vue/shared dist/shared.cjs.prod.js to

function escapeHtmlComment(src) {
  return src.toString().replace(commentStripRE, "");
}

, the error no longer occurs.
Running environment:

------------------------------
- Operating System: Linux
- Node Version:     v18.20.5
- Nuxt Version:     3.14.159
- CLI Version:      3.14.0
- Nitro Version:    2.10.4
- Package Manager:  [email protected]
- Builder:          -
- User Config:      -
- Runtime Modules:  -
- Build Modules:    -
------------------------------

[edison1105]

Thanks for the PR. This might fix your problem, but we need more context to analyze the root cause. Please provide a runnable minimal reproduction so that we can investigate the issue.

[lazytong-tech]

I created a demo at https://cloudstudio.net/a/23155491845591040

[edison1105]

@lazytong-tech
Thank you for providing the reproduction, it indeed replicates the issue you described. However, the code cannot be downloaded, and I would like to debug it locally to see what the input parameters are.

[lazytong-tech]

you can download it at https://f002.backblazeb2.com/file/lazytong/demo.zip