fix(compiler-core): prevent incorrect entity parsing with logical AND

[edison1105]

close #13361

Summary by CodeRabbit

• Bug Fixes
  • Improved parsing to correctly handle logical AND (&&) operators in directive attribute values, preventing them from being misinterpreted as HTML entities.
• Tests
  • Added a test to verify correct parsing of multiline directive values containing logical operators.

[coderabbitai]

Walkthrough

A new test was added to verify correct parsing of multiline directive values in the compiler. The tokenizer logic was updated to distinguish between ampersands used in logical AND operators and those used for HTML entities, preventing misinterpretation of logical AND sequences as entities during parsing.

Changes

File(s)	Change Summary
packages/compiler-core/tests/parse.spec.ts	Added a test to check correct AST location end line for multiline v-if directive values.
packages/compiler-core/src/tokenizer.ts	Added isLogicalAnd() method; updated logic to avoid treating logical AND (&&) as HTML entities in tokenizer.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure correct template location tracking for multiline directive values (#13361)	✅

Poem

The tokenizer hops with glee,
No longer fooled by ampersand spree.
Multiline v-if, parsed just right—
Test cases now pass without a fight.
With logic clear and bugs at bay,
The rabbit coder hops away! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between d53daf1 and 47bb99c.

📒 Files selected for processing (2)

• packages/compiler-core/__tests__/parse.spec.ts (1 hunks)
• packages/compiler-core/src/tokenizer.ts (5 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Redirect rules
• GitHub Check: Header rules
• GitHub Check: Pages changed

🔇 Additional comments (6)

packages/compiler-core/src/tokenizer.ts (5)

1182-1187: Well-designed helper method for detecting logical AND operators

This new isLogicalAnd() method elegantly solves the issue by checking if the current ampersand is part of a logical AND operator (&&) by examining adjacent characters. The implementation is simple and effective.

---

325-325: Good fix for entity parsing in text nodes

Checking for logical AND operators before attempting entity decoding in text nodes prevents misinterpretation of && as HTML entities, addressing the core issue in the PR.

---

439-439: Properly handles RCDATA content

The fix correctly applies the same logical AND check in RCDATA content (like <title> and <textarea> tags), ensuring consistent behavior across different node types.

---

798-798: Good fix for entity parsing in attribute values

Applying the logical AND check in attribute values with quotes ensures correct parsing of expressions like v-if="condition1 && condition2".

---

826-826: Comprehensive fix for unquoted attribute values

The implementation correctly handles the logical AND check in unquoted attribute values as well, making the fix comprehensive across all tokenizer states.

packages/compiler-core/__tests__/parse.spec.ts (1)

1267-1276: Great test case for issue #13361

This test case effectively validates the fix for incorrect entity parsing with logical AND operators. By testing a multiline v-if directive with logical AND operators, it ensures that the parser correctly handles these scenarios and maintains proper location tracking in the AST.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB	38.3 kB	34.6 kB
vue.global.prod.js	159 kB (+107 B)	58.5 kB (+32 B)	52.1 kB (+95 B)

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.6 kB	18.2 kB	16.7 kB
createApp	54.5 kB	21.2 kB	19.4 kB
createSSRApp	58.8 kB	23 kB	20.9 kB
defineCustomElement	59.5 kB	22.8 kB	20.8 kB
overall	68.6 kB	26.4 kB	24.1 kB

[pkg-pr-new]

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13363

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13363

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13363

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13363

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13363

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13363

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13363

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13363

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13363

vue

npm i https://pkg.pr.new/vue@13363

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13363

commit: 47bb99c