Skip to content

Conversation

9romise
Copy link

@9romise 9romise commented Sep 29, 2025

  1. Replaced tseslint.config with defineConfig from eslint/config, since tseslint.config was deprecated in [email protected].

  2. Replaced @typescript-eslint/prefer-ts-expect-error with @typescript-eslint/ban-ts-comment, as the former has been deprecated and the latter provides a more powerful and configurable alternative.

Summary by CodeRabbit

  • New Features

    • No user-facing changes.
  • Chores

    • Updated ESLint setup to use a new configuration wrapper and replaced a TypeScript lint rule for comment handling. No impact on runtime behavior or public APIs.
  • Style

    • Adjusted ESLint disable directives in TypeScript declaration files to align with the updated lint rule. No changes to typings or functionality.

@coderabbitai
Copy link

coderabbitai bot commented Sep 29, 2025

Walkthrough

Updated ESLint configuration to use defineConfig and switch from prefer-ts-expect-error to ban-ts-comment. Adjusted ESLint disable directives in Vue JSX type declaration files accordingly. No runtime or type declaration changes.

Changes

Cohort / File(s) Summary of changes
ESLint config export and rules
eslint.config.js
Switched default export from tseslint.config({...}) to defineConfig({...}); imported defineConfig from eslint/config; replaced rule @typescript-eslint/prefer-ts-expect-error with @typescript-eslint/ban-ts-comment (minimumDescriptionLength: 0).
Vue JSX typings lint directives
packages/vue/jsx-runtime/index.d.ts, packages/vue/jsx.d.ts
Replaced file-level ESLint disable from @typescript-eslint/prefer-ts-expect-error to @typescript-eslint/ban-ts-comment; no type/export changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A bunny tweaks the linting lore, 🐇
Swaps comments at the burrow door.
defineConfig now sets the scene,
JS and TS kept crisp and clean.
With gentle paws, no types impaired—
Just tidier trails, well-prepared.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title accurately and concisely summarizes the two main changes introduced in the pull request—swapping out the deprecated ts-eslint configuration wrapper and replacing the deprecated lint rule—using clear phrasing and conventional commit format without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a8aa0b and 1f70ed1.

📒 Files selected for processing (3)
  • eslint.config.js (3 hunks)
  • packages/vue/jsx-runtime/index.d.ts (1 hunks)
  • packages/vue/jsx.d.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules
  • GitHub Check: Header rules
  • GitHub Check: Pages changed

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🧹 p1-chore Priority 1: this doesn't change code behavior. labels Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧹 p1-chore Priority 1: this doesn't change code behavior. ready to merge The PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants