test(display): use effectScope

vuetifyjs · Feb 3, 2025 · 1950f2b · 1950f2b
1 parent a5efcf1
commit 1950f2b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/packages/vuetify/src/composables/__tests__/display.spec.browser.ts b/packages/vuetify/src/composables/__tests__/display.spec.browser.ts
@@ -3,6 +3,7 @@ import { createDisplay } from '../display'
 
 // Utilities
 import { page } from '@vitest/browser/context'
+import { effectScope } from 'vue'
 
 const breakpoints = [
   'xs',
@@ -262,7 +263,8 @@ describe('display', () => {
   ])('should calculate breakpoint for $description', async (options, expected) => {
     await page.viewport(options.width, options.height)
 
-    const display = createDisplay()
+    const scope = effectScope()
+    const display = scope.run(() => createDisplay())!
 
     const matched = breakpoints.reduce<(typeof breakpoints[number])[]>((acc, breakpoint) => {
       if (display[breakpoint].value) acc.push(breakpoint)
@@ -273,9 +275,10 @@ describe('display', () => {
   })
 
   it('should override default thresholds', async () => {
-    const { name } = createDisplay({
+    const scope = effectScope()
+    const { name } = scope.run(() => createDisplay({
       thresholds: { sm: 400 },
-    })
+    }))!
 
     await page.viewport(400, 900)
     await expect.poll(() => name.value).toBe('sm')
@@ -285,7 +288,8 @@ describe('display', () => {
   })
 
   it('should allow breakpoint strings for mobileBreakpoint', async () => {
-    const { mobile } = createDisplay({ mobileBreakpoint: 'lg' })
+    const scope = effectScope()
+    const { mobile } = scope.run(() => createDisplay({ mobileBreakpoint: 'lg' }))!
 
     await page.viewport(1920, 900)
     await expect.poll(() => mobile.value).toBe(false)

diff --git a/packages/vuetify/src/framework.ts b/packages/vuetify/src/framework.ts
@@ -140,7 +140,7 @@ export function createVuetify (vuetify: VuetifyOptions = {}) {
       date,
       goTo,
     }
-  })
+  })!
 }
 
 export const version = __VUETIFY_VERSION__
-Original file line number
+Diff line change
@@ Expand Up @@
           date,
           goTo,
         }
-      })
+      })!
     }
     export const version = __VUETIFY_VERSION__
@@ Expand Down @@