Partial solution for Exercise 3 #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuksa
reviewed
Apr 6, 2024
| TODO("Implement me!!!") | ||
| val stack = mutableListOf<Char>() | ||
|
|
||
| for (char in expression) { |
There was a problem hiding this comment.
Well done! For practice, try solving it with a functional approach. :)
vuksa
reviewed
Apr 6, 2024
| @@ -10,29 +10,56 @@ package exercise3.task4 | |||
| * Find all the drivers who performed no trips. | |||
| */ | |||
| internal fun TaxiPark.findFakeDrivers(): Set<Driver> { | |||
| TODO("Implement me!!!") | |||
| return allDrivers.filter { driver -> trips.none { it.driver == driver } } | |||
There was a problem hiding this comment.
This is a correct solution, but its performance is not great because we'll have to do D * T iterations, where D is the number of drivers, and T is the number of trips.
The same solution can be done by mapping all the drivers from trips and then deducting all drivers from the list of drivers present in trips.
allDrivers - trips.map { it.driver }
This way we only once iterate over the trips list.
vuksa
reviewed
Apr 6, 2024
|
|
||
| return passengerDiscountTripsCount | ||
| .filter { (_, discounts) -> | ||
| discounts >= trips.size / 2 |
There was a problem hiding this comment.
Why are we comparing this with half of all trips? Shouldn't we compare against half of the trips this user made?
vuksa
force-pushed
the
main
branch
3 times, most recently
from
6106c56 to
8296ece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Programing language Kotlin course - Assignment Submission For Exercise 3 (Except Task 3)
👨🎓👩🎓 Full name of the Author
Full name: Slobodan Vukojevic
✅ Checklist