Finished exercise 7 #4

bojanludajic · 2024-03-22T12:29:24Z

No description provided.

vuksa · 2024-03-26T09:50:03Z

src/main/kotlin/exercise2/task1/FindPairOfHighestSum.kt

+    val prvi = this.sorted().get(this.lastIndex)
+    val drugi = this.sorted().get(this.lastIndex-1)


There is no need to sort the array twice. Please name the variables in English, as that is a widely accepted convention.

vuksa · 2024-03-26T09:56:13Z

src/main/kotlin/exercise2/task2/FindPairOfHighestSumFunctional.kt

@@ -20,7 +20,9 @@ import org.jetbrains.exercise2.task3.findPairWithBiggestDifference
 */

 internal fun List<Int>.findHighestSumPairFunctional(): Pair<Int, Int> {
-    TODO("Implement me!!")
+    return Pair(
+        this.sorted().get(this.lastIndex), this.sorted().get(this.lastIndex-1)


This is not a functional approach :)

The idea of the functional approach is that you compose function calls that operate on data to get the desired result.

Functional approach would be following:

Suggested change

this.sorted().get(this.lastIndex), this.sorted().get(this.lastIndex-1)

return this.sorted().let { sortedList -> Pair(this.lastIndex, this.lastIndex-1) }

In this case, we are using the result of the sorted function invocation, and we are providing it as an input of the let function invocation. Hence, we are composing function calls to get the result.

vuksa · 2024-03-26T10:10:26Z

src/main/kotlin/exercise2/task3/ConvertMethodToFunctionalApproach.kt


-    return resultPair!!
+    return Pair(
+        this.sorted().get(this.size-1), this.sorted().get(0)


The solution is correct, but it is written in Java-style code. Please consider my suggestion above to implement it in a Kotlin, functional style. :)

Also, this.size - 1 has a Kotlin equivalent in this.lastIndex, and get(0) has an equivalent in a first() function.

vuksa · 2024-03-26T10:10:42Z

src/main/kotlin/exercise2/task3/ConvertMethodToFunctionalApproach.kt

+    )
+
+
+//    var resultPair: Pair<Int, Int>? = null


Please clean up the code before pushing the changes.

vuksa · 2024-03-26T10:11:12Z

src/main/kotlin/exercise2/task4/ProcessCountriesData.kt

 }

 internal fun List<Country>.findLanguageSpokenInMostCountries(): String {
-    TODO("Implement me!!!")
+    return countries.flatMap { it.languages }


Very nice solution!

vuksa · 2024-03-26T10:11:31Z

src/main/kotlin/exercise2/task5/CreateUserDSL.kt

@@ -49,11 +49,15 @@ internal data class Address(
 */

 internal fun user(initUser: User.() -> Unit): User {
-    TODO("Implement me!!!")
+    val user = User()
+    return user.apply(initUser)


nit: this can be a one-line expression :)

vuksa · 2024-03-26T10:11:49Z

src/main/kotlin/exercise2/task5/CreateUserDSL.kt

-internal fun User.address(initAddress: Address.() -> Unit): User {
-    TODO("Implement me!!!")
+internal fun User.address   (initAddress: Address.() -> Unit): User {
+    val adr = Address()


That's it! Why not using apply scoped function here as well?

vuksa · 2024-03-26T10:16:48Z

Please try going one more time through functional programming, and what the way is to work with collections in a Kotlin style. The task about countries showed that you can do it, but your solutions for finding pairs need to have a functional approach to solving the problem as well.

One side note: when you write code, please write code in English(name methods and variables in English). It is a widely spread convention, and once you get into the industry, you'll work in an international environment, which will require you to write code in such a way. Also, please keep your code clean, and do not push commented-out code. :)

…ming-language-course

vuksa · 2024-04-06T12:51:51Z

src/main/kotlin/exercise3/task1/BalancedBrackets.kt

@@ -26,9 +27,32 @@ package exercise3.task1


 internal fun isExpressionBalanced(expression: String): Boolean {
-    TODO("Implement me!!!")
+    val chars = Stack<Char>()


The solution is correct. 👏🏻
Please now try solving it in the functional way. :)

vuksa · 2024-04-06T12:52:36Z