Solutions for exercises No.3 #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuksa
force-pushed
the
main
branch
2 times, most recently
from
9db668d to
189c667
Compare
vuksa
reviewed
Apr 6, 2024
| val stack = LinkedList<Char>() | ||
| expression.forEach { | ||
| when (it) { | ||
| in brackets.values -> stack.push(it) |
There was a problem hiding this comment.
This is the correct implementation. 👏🏻
One potential nitpick here is that you are creating a new list of values and keys on every item you iterate, which can be improved if we assigned brackets.values and brackets.keys to variables before we start iterating over the chars in the expression.
vuksa
reviewed
Apr 6, 2024
| @@ -10,29 +10,49 @@ package exercise3.task4 | |||
| * Find all the drivers who performed no trips. | |||
| */ | |||
| internal fun TaxiPark.findFakeDrivers(): Set<Driver> { | |||
| TODO("Implement me!!!") | |||
| return this.allDrivers.minus(this.trips.map { it.driver } | |||
| .intersect(this.allDrivers)) | |||
There was a problem hiding this comment.
We do not need an intersect call here.
Its enough to subtract allDrivers - trips.map { it.drivers } to get the result.
vuksa
reviewed
Apr 6, 2024
| } | ||
|
|
||
| /** | ||
| * Subtask 2: | ||
| * Find all the clients who completed at least the given number of trips. | ||
| */ | ||
| internal fun TaxiPark.findFaithfulPassengers(minTrips: Int): Set<Passenger> { | ||
| TODO("Implement me!!!") | ||
| println(this.trips.flatMap { it.passengers } |
vuksa
reviewed
Apr 6, 2024
| .groupingBy { it } | ||
| .eachCount()) | ||
|
|
||
| return this.trips.flatMap { it.passengers } |
vuksa
reviewed
Apr 6, 2024
| TODO("Implement me!!!") | ||
| return this.trips | ||
| .filter { it.discount != null } | ||
| .flatMap { it.passengers } |
There was a problem hiding this comment.
Your solution returns a set of passengers who had at least one trip with the discount.
The assignment request is to return a list of passengers who had more than half of the trips with the discount.
vuksa
force-pushed
the
main
branch
3 times, most recently
from
6106c56 to
8296ece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.