Skip to content

feat: DELETE /unregister endpoint#6

Merged
johnnyluo merged 3 commits intomainfrom
feat/unregister-endpoint
Feb 25, 2026
Merged

feat: DELETE /unregister endpoint#6
johnnyluo merged 3 commits intomainfrom
feat/unregister-endpoint

Conversation

@gastonm5
Copy link
Contributor

Summary

  • Add DELETE /unregister/:vault_id/:party_name endpoint to allow devices to remove their push notification registration by vault ID and local party ID
  • Add UnregisterDeviceByParty storage method that hard-deletes the device record matching the composite unique index (vault_id, party_name)
  • Update README with endpoint documentation

Test plan

  • Call DELETE /unregister/<vault_id>/<party_name> with a registered device and verify the record is removed from the database
  • Call DELETE /unregister/<vault_id>/<party_name> with a non-existent combo and verify a 500 response
  • Verify that POST /register still works after unregistering (re-registration)

Copy link
Contributor

@johnnyluo johnnyluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnnyluo johnnyluo merged commit e3b5f8a into main Feb 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants