Skip to content

Reduces amount of memory allocations #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

azeno
Copy link
Member

@azeno azeno commented Feb 21, 2021

For details see issue #4

Note that this commit contains changes in the C# helper project. To test these changes one needs to delete the pre-shipped vvvv/lib/VL.IO.OSC.dll inside the vvvv installation folder.

- UnpackMessage and UnpackString use Span
- MessagePattern.IsMatch now static method based on span as well. Will only allocate if regex is indeed used.
- Use more memory friendly value tuple in OSCServer
@azeno azeno force-pushed the less-memory-allocations branch from cbe6b4a to 02c0635 Compare February 21, 2021 13:33
@azeno azeno changed the title UnpackString and UnpackMessage use span APIs to reduce amount of memory allocations Reduces amount of memory allocations Feb 21, 2021
@azeno
Copy link
Member Author

azeno commented Feb 21, 2021

2021.3
image

2021.3.1-0072 with this PR applied
image

@joreg joreg merged commit ae7055e into vvvv:master Feb 23, 2021
@azeno azeno deleted the less-memory-allocations branch February 25, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants