-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help patch cleanups and harmonization #50
Conversation
…tes HowTo Apply boolean operations on images in replacement. Adds to #47 and # 48
In 4f4844a, I drastically simplified the HowTo Count pixel that are not black. It was bloated with too many nodes, which made the very goal of the patch unclear. Happy to discuss! |
In the case of OpenCV we try to copy the image data or allocate new memory as little as possible for efficiency, this means that we reuse the same image reference (or the same memory) over and over which is fine for most cases. However there are cases in which you need to further do stuff with the image (modify it), or cases in which the image is being written into from another thread while you are reading it, both of which would give you memaccess and corrupted data problems either upstream or downstream. In general, to avoid reading into memory which may be being written into or which may not be ready, you can use HoldLatestCopy which will just copy the data over and hold the copy, allowing any further processing on the original image to be of no concern to you, this of course comes with a cost. As a rule of thumb always try using HoldLatest unless it gives you issues, in which case you should use HoldLatestCopy. @azeno can probably explain this in much more detail. |
…ailable Filter nodes. To be updated. Adds to #47
@ravazquez Thanks, that's clear to me and surely enough for some in-patch explanations. |
… HowTo Retrieve camera characteristics from camera calibration.
…lp flags and cleans the patch.
Opening this PR so we can discuss things about help patches cleaning before merging.
In 340ff31, i reworked patches from the General category. I'd like to show some information on why
HoldLatestCopy
is used in HowTo Apply operations asynchronously instead of a plainHoldLatest
. Guess it has to do with the fact that we're dealing with images here, but could you shed some light on this @ravazquez ?Thanks!