Resolve ESLint warnings before package extraction (Fixes #1569)

eslint.config.js

@@ -333,6 +333,18 @@ export default tseslint.config(
       // Expensive heuristic — NLP analysis on comments with no value for this codebase
       'sonarjs/no-commented-code': 'off',
 
+      // False-positive or redundant sonarjs rules — see project-plans/issue1569b/README.md
+      'sonarjs/declarations-in-global-scope': 'off', // ESM false positives
+      'sonarjs/no-unused-vars': 'off', // Redundant with @typescript-eslint/no-unused-vars
+      'sonarjs/max-lines-per-function': 'off', // Redundant with base max-lines-per-function at 80
+      'sonarjs/process-argv': 'off', // CLI tool legitimately uses process.argv
+      'sonarjs/standard-input': 'off', // CLI tool legitimately uses stdin
+      'sonarjs/publicly-writable-directories': 'off', // Test /tmp usage is intentional
+      'sonarjs/pseudo-random': 'off', // Non-cryptographic context (IDs, shuffles)
+      'sonarjs/no-reference-error': 'off', // TypeScript ambient/global false positives
+      'sonarjs/no-undefined-assignment': 'off', // TypeScript undefined convention
+      'sonarjs/arrow-function-convention': 'off', // Conflicts with Prettier arrowParens: "always" default
+
       // ESLint comments (recommended rules downgraded to warn)
       ...Object.fromEntries(
         Object.entries(eslintComments.configs.recommended.rules ?? {}).map(
@@ -454,6 +466,7 @@ export default tseslint.config(
 
       // Relax complexity rules for test files
       'max-lines-per-function': 'off',
+      'sonarjs/no-duplicate-string': 'off', // Tests repeat strings legitimately
     },
   },
   // Issue #1576: Enforce strict line-limit errors on AppContainer module files.

packages/a2a-server/src/agent/executor.ts

@@ -101,10 +101,10 @@ export class CoderAgentExecutor implements AgentExecutor {
     sdkTask: SDKTask,
     eventBus?: ExecutionEventBus,
   ): Promise<TaskWrapper> {
-    const metadata = sdkTask.metadata || {};
+    const metadata = sdkTask.metadata ?? {};
     const persistedState = getPersistedState(metadata);
 
-    if (!persistedState) {
+    if (persistedState == null) {
       throw new Error(
         `Cannot reconstruct task ${sdkTask.id}: missing persisted state in metadata.`,
       );
@@ -123,7 +123,7 @@ export class CoderAgentExecutor implements AgentExecutor {
     runtimeTask.taskState = persistedState._taskState;
     const contentGeneratorConfig =
       runtimeTask.config.getContentGeneratorConfig();
-    if (contentGeneratorConfig) {
+    if (contentGeneratorConfig != null) {
       await runtimeTask.geminiClient.initialize(contentGeneratorConfig);
     }
 
@@ -139,7 +139,7 @@ export class CoderAgentExecutor implements AgentExecutor {
     agentSettingsInput?: AgentSettings,
     eventBus?: ExecutionEventBus,
   ): Promise<TaskWrapper> {
-    const agentSettings = agentSettingsInput || ({} as AgentSettings);
+    const agentSettings = agentSettingsInput ?? ({} as AgentSettings);
     const config = await this.getConfig(agentSettings, taskId);
     const runtimeTask = await Task.create(
       taskId,
@@ -150,7 +150,7 @@ export class CoderAgentExecutor implements AgentExecutor {
     );
     const contentGeneratorConfig2 =
       runtimeTask.config.getContentGeneratorConfig();
-    if (contentGeneratorConfig2) {
+    if (contentGeneratorConfig2 != null) {
       await runtimeTask.geminiClient.initialize(contentGeneratorConfig2);
     }
 
@@ -177,13 +177,12 @@ export class CoderAgentExecutor implements AgentExecutor {
     );
     const wrapper = this.tasks.get(taskId);
 
-    if (!wrapper) {
+    if (wrapper == null) {
       logger.warn(
         `[CoderAgentExecutor] Task ${taskId} not found for cancellation.`,
       );
       eventBus.publish({
         kind: 'status-update',
-        taskId,
         contextId: uuidv4(),
         status: {
           state: 'failed',
@@ -196,6 +195,7 @@ export class CoderAgentExecutor implements AgentExecutor {
           },
         },
         final: true,
+        taskId,
       });
       return;
     }
@@ -208,7 +208,6 @@ export class CoderAgentExecutor implements AgentExecutor {
       );
       eventBus.publish({
         kind: 'status-update',
-        taskId,
         contextId: task.contextId,
         status: {
           state: task.taskState,
@@ -226,6 +225,7 @@ export class CoderAgentExecutor implements AgentExecutor {
           },
         },
         final: true,
+        taskId,
       });
       return;
     }
@@ -260,7 +260,6 @@ export class CoderAgentExecutor implements AgentExecutor {
       );
       eventBus.publish({
         kind: 'status-update',
-        taskId,
         contextId: task.contextId,
         status: {
           state: 'failed',
@@ -278,6 +277,7 @@ export class CoderAgentExecutor implements AgentExecutor {
           },
         },
         final: true,
+        taskId,
       });
     }
   };
@@ -289,11 +289,11 @@ export class CoderAgentExecutor implements AgentExecutor {
     const userMessage = requestContext.userMessage;
     const sdkTask = requestContext.task;
 
-    const taskId = sdkTask?.id || userMessage.taskId || uuidv4();
+    const taskId = sdkTask?.id ?? userMessage.taskId ?? uuidv4();
     const contextId =
-      userMessage.contextId ||
-      sdkTask?.contextId ||
-      sdkTask?.metadata?.['_contextId'] ||
+      userMessage.contextId ??
+      sdkTask?.contextId ??
+      (sdkTask?.metadata?.['_contextId'] as string | undefined) ??
       uuidv4();
 
     logger.info(
@@ -307,7 +307,7 @@ export class CoderAgentExecutor implements AgentExecutor {
     );
 
     const store = requestStorage.getStore();
-    if (!store) {
+    if (store == null) {
       logger.error(
         '[CoderAgentExecutor] Could not get request from async local storage. Cancellation on socket close will not be handled for this request.',
       );
@@ -316,7 +316,7 @@ export class CoderAgentExecutor implements AgentExecutor {
     const abortController = new AbortController();
     const abortSignal = abortController.signal;
 
-    if (store) {
+    if (store != null) {
       // Grab the raw socket from the request object
       const socket = store.req.socket;
       const onClientEnd = () => {
@@ -344,10 +344,10 @@ export class CoderAgentExecutor implements AgentExecutor {
 
     let wrapper: TaskWrapper | undefined = this.tasks.get(taskId);
 
-    if (wrapper) {
+    if (wrapper != null) {
       wrapper.task.eventBus = eventBus;
       logger.info(`[CoderAgentExecutor] Task ${taskId} found in memory cache.`);
-    } else if (sdkTask) {
+    } else if (sdkTask != null) {
       logger.info(
         `[CoderAgentExecutor] Task ${taskId} found in TaskStore. Reconstructing...`,
       );
@@ -363,7 +363,6 @@ export class CoderAgentExecutor implements AgentExecutor {
         };
         eventBus.publish({
           kind: 'status-update',
-          taskId,
           contextId: sdkTask.contextId,
           status: {
             state: 'failed',
@@ -377,12 +376,13 @@ export class CoderAgentExecutor implements AgentExecutor {
                 },
               ],
               messageId: uuidv4(),
-              taskId,
               contextId: sdkTask.contextId,
+              taskId,
             } as Message,
           },
           final: true,
           metadata: { coderAgent: stateChange },
+          taskId,
         });
         return;
       }
@@ -393,7 +393,7 @@ export class CoderAgentExecutor implements AgentExecutor {
       ] as AgentSettings;
       wrapper = await this.createTask(
         taskId,
-        contextId as string,
+        contextId,
         agentSettings,
         eventBus,
       );
@@ -415,13 +415,6 @@ export class CoderAgentExecutor implements AgentExecutor {
       }
     }
 
-    if (!wrapper) {
-      logger.error(
-        `[CoderAgentExecutor] Task ${taskId} is unexpectedly undefined after load/create.`,
-      );
-      return;
-    }
-
     const currentTask = wrapper.task;
 
     if (['canceled', 'failed', 'completed'].includes(currentTask.taskState)) {

packages/a2a-server/src/agent/task.test.ts

@@ -73,7 +73,7 @@ describe('Task', () => {
 
     await task.scheduleToolCalls(requests, abortController.signal);
 
-    expect(requests).toEqual(originalRequests);
+    expect(requests).toStrictEqual(originalRequests);
   });
 
   describe('acceptAgentMessage', () => {
@@ -145,7 +145,7 @@ describe('Task', () => {
 
       // Access private field for testing
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      expect((task as any).modelInfo).toEqual({
+      expect((task as any).modelInfo).toStrictEqual({
         model: 'gemini-2.0-flash-exp',
       });
     });
@@ -286,7 +286,7 @@ describe('Task', () => {
 
       // Should have the latest modelInfo
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      expect((task as any).modelInfo).toEqual({
+      expect((task as any).modelInfo).toStrictEqual({
         model: 'gemini-2.0-flash-exp',
       });
     });

packages/a2a-server/src/agent/task.ts

@@ -5,7 +5,7 @@
  */
 
 import {
-  CoreToolScheduler,
+  type CoreToolScheduler,
   GeminiClient,
   GeminiEventType,
   ToolConfirmationOutcome,
@@ -37,7 +37,7 @@ import type {
   ModelInfo,
 } from '@vybestack/llxprt-code-core';
 import type { RequestContext } from '@a2a-js/sdk/server';
-import { type ExecutionEventBus } from '@a2a-js/sdk/server';
+import type { ExecutionEventBus } from '@a2a-js/sdk/server';
 import type {
   TaskStatusUpdateEvent,
   TaskArtifactUpdateEvent,
@@ -185,7 +185,10 @@ export class Task {
       this.toolCompletionNotifier = { resolve, reject };
     });
     // If there are no pending calls when reset, resolve immediately.
-    if (this.pendingToolCalls.size === 0 && this.toolCompletionNotifier) {
+    if (
+      this.pendingToolCalls.size === 0 &&
+      this.toolCompletionNotifier != null
+    ) {
       this.toolCompletionNotifier.resolve();
     }
   }
@@ -207,7 +210,10 @@ export class Task {
       logger.info(
         `[Task] Resolved tool call: ${toolCallId}. Pending: ${this.pendingToolCalls.size}`,
       );
-      if (this.pendingToolCalls.size === 0 && this.toolCompletionNotifier) {
+      if (
+        this.pendingToolCalls.size === 0 &&
+        this.toolCompletionNotifier != null
+      ) {
         this.toolCompletionNotifier.resolve();
       }
     }
@@ -229,7 +235,7 @@ export class Task {
         `[Task] Cancelling all ${this.pendingToolCalls.size} pending tool calls. Reason: ${reason}`,
       );
     }
-    if (this.toolCompletionNotifier) {
+    if (this.toolCompletionNotifier != null) {
       this.toolCompletionNotifier.reject(new Error(reason));
     }
     this.pendingToolCalls.clear();
@@ -243,11 +249,11 @@ export class Task {
   ): Message {
     return {
       kind: 'message',
-      role,
       parts: [{ kind: 'text', text }],
       messageId: uuidv4(),
       taskId: this.id,
       contextId: this.contextId,
+      role,
     };
   }
 
@@ -286,8 +292,8 @@ export class Task {
       contextId: this.contextId,
       status: {
         state: stateToReport,
-        message, // Shorthand property
         timestamp: timestamp || new Date().toISOString(),
+        message,
       },
       final,
       metadata,
@@ -308,7 +314,7 @@ export class Task {
 
     if (messageText) {
       message = this._createTextMessage(messageText);
-    } else if (messageParts) {
+    } else if (messageParts != null) {
       message = {
         kind: 'message',
         role: 'agent',
@@ -361,9 +367,9 @@ export class Task {
       kind: 'artifact-update',
       taskId: this.id,
       contextId: this.contextId,
-      artifact,
       append: true,
       lastChunk: false,
+      artifact,
     };
     this.eventBus?.publish(artifactEvent);
   }
@@ -549,7 +555,7 @@ export class Task {
       'response',
     );
 
-    if (tc.tool) {
+    if (tc.tool != null) {
       serializableToolCall.tool = this._pickFields(
         tc.tool,
         'name',
@@ -712,7 +718,7 @@ export class Task {
                   const request = updatedRequests.find(
                     (req) => req.callId === callId,
                   );
-                  if (request) {
+                  if (request != null) {
                     request.checkpoint = checkpointPath;
                     logger.info(
                       `[Task] Checkpoint created for callId ${callId}: ${checkpointPath}`,
@@ -734,7 +740,7 @@ export class Task {
       }
     }
 
-    if (!this.scheduler) {
+    if (this.scheduler == null) {
       throw new Error('Scheduler not initialized');
     }
     await this.scheduler.schedule(updatedRequests, abortSignal);
@@ -875,7 +881,7 @@ export class Task {
 
     const confirmationDetails = this.pendingToolConfirmationDetails.get(callId);
 
-    if (!confirmationDetails) {
+    if (confirmationDetails == null) {
       logger.warn(
         `[Task] Received tool confirmation for unknown or already processed callId: ${callId}`,
       );