Skip to content

Conversation

@FrittenKeeZ
Copy link

Described in #635 and #636 - implementing the direct fix from the latter.

@FrittenKeeZ
Copy link
Author

@khepin @vyuldashev can one of you take a look at this?

@alexeydotsenko
Copy link

alexeydotsenko commented Oct 23, 2025

Looks like just

protected $config;

public function getConfig(): QueueConfig
{
    return $this->config;
}

public function setConfig(array $config)
{
    $this->config = QueueConfigFactory::make($config);

    return $this;
}

will be enough

@FrittenKeeZ
Copy link
Author

@alexeydotsenko nope, Laravel's $config is expected to be an array.

@alexeydotsenko
Copy link

They do not lock a type of $config variable to array. According to a code configuration will be provided as array, but we can store it in any format. So we can do it without extra code changes

@FrittenKeeZ
Copy link
Author

That is very risky, since usage of getConfig() might cause fatal errors in the future if the using code expects an array.
Otherwise QueueConfig should implement the necessary interfaces to act like an array.

@duykb2015
Copy link

Oh my. Please review this - my app is down now 😭

@FrittenKeeZ
Copy link
Author

@duykb2015 downgrade to Laravel 12.33 for now.

@duykb2015
Copy link

@FrittenKeeZ it’s all good now. I copied your file and it’s working. Thank you so much, you saved me!

@Crmteam-IVG
Copy link

Please review the changes @khepin @vyuldashev

@dzatona
Copy link

dzatona commented Oct 25, 2025

Temp workaround: #639 (comment)

@mihob
Copy link

mihob commented Oct 26, 2025

@khepin @vyuldashev Any news on this?

@FrittenKeeZ
Copy link
Author

Tests are failing because #628 hasn't been merged

Crmteam-IVG pushed a commit to Crmteam-IVG/laravel-queue-rabbitmq that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants