Add a recommendation section and a security section for payload sizes #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pstlouis <[email protected]>
PatStLouis
requested review from
msporny,
mavarley and
mkhraisha
as code owners
dlongley
approved these changes
Feb 4, 2025
Co-authored-by: Dave Longley <[email protected]>
TallTed
suggested changes
Feb 5, 2025
| @@ -719,6 +719,12 @@ <h3>Handling Unknown Options and Data</h3> | |||
| Implementations MUST throw an error if an endpoint receives data, options, or option values that it | |||
| does not understand or know how to process. | |||
| </p> | |||
| <h4>Payload Sizes</h4> | |||
| <p>Implementations are encouraged to pay attention to the payload sizes of the Verifiable Credentials they issue.</p> | |||
| <p>Presentations can bundle a large volume of credentials, resulting in a higher request size than anticipated. This heightens the risk of interoperability issues.</p> | |||
There was a problem hiding this comment.
a higher request size?
Is this not a higher { result | return | presentation | something-else } size
There was a problem hiding this comment.
The group discussed this on the 2025-02-18: @dlongley noted that we are talking about the request size... client posting VP with lots of credentials in it and that's what's being checked.
There was a problem hiding this comment.
Suggested change
| <p>Presentations can bundle a large volume of credentials, resulting in a higher request size than anticipated. This heightens the risk of interoperability issues.</p> | |
| <p>Presentations can bundle a large volume of credentials, which can result in a higher request size than anticipated by implementers and/or deployers. This raises the risk of interoperability issues.</p> |
| <p>Implementations are encouraged to pay attention to the payload sizes of the Verifiable Credentials they issue.</p> | ||
| <p>Presentations can bundle a large volume of credentials, resulting in a higher request size than anticipated. This heightens the risk of interoperability issues.</p> | ||
| <p>A default maximum size of 10MB per Verifiable Credential is recommended as an interoperability baseline, with the possibility of configuring a larger size if required. The configuration should be detailed at an instance level. | ||
| This also accounts for the 16MB size limit of most document-based storage database solutions.</p> |
There was a problem hiding this comment.
Suggested change
| This also accounts for the 16MB size limit of most document-based storage database solutions.</p> | |
| This also accommodates the 16MB size limit of most document-based database storage solutions.</p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #437
Preview | Diff