-
Notifications
You must be signed in to change notification settings - Fork 37
Issue 534: Support for property paths in SHACL UI #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose removing the targets from the examples. Only the section about target finding should contain them. The other sections should not need them, which makes the examples shorter and easier to grasp.
The rest looks good to me.
|
I’m wondering if we should mention the restrictions on alternative paths in edit mode as described in #534 (comment), specifically on which predicate paths are allowed. Should we also add a paragraph on the challenges of supporting complex paths in edit mode? Otherwise, everything else looks good to me. |
Apply suggestions from code review Co-authored-by: Thomas Bergwinkl <[email protected]>
|
@edmondchuc I’ve pushed a commit that addresses your comment. Is it what you had in mind, or are there specific things you’re missing, or is it too verbose? I’m open to suggestions. |
|
@smessie I think your last additions to alternative path and other complex paths are very useful. One small thing: Can you add a shape to the Other Complex Paths example? I think it would be useful to show |
|
@bergos I wasn't sure yet if a sequence path ( |
|
@smessie not required to change anything. The path is fine like it is. |
|
Screenshots may still be overly ambitious, but wireframes may be helpful to comprehension. |
The document currently lacks screenshots but provides descriptions of the UI. We can add screenshots of potential UIs later, e.g., once we have a first implementation of a SHACL UI library.
Contributes to #534