Skip to content

Conversation

@smessie
Copy link
Member

@smessie smessie commented Oct 9, 2025

The document currently lacks screenshots but provides descriptions of the UI. We can add screenshots of potential UIs later, e.g., once we have a first implementation of a SHACL UI library.

Contributes to #534

@smessie smessie requested review from bergos and edmondchuc October 9, 2025 13:45
@smessie smessie added the UI For SHACL 1.2 UI spec label Oct 9, 2025
Copy link
Contributor

@bergos bergos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose removing the targets from the examples. Only the section about target finding should contain them. The other sections should not need them, which makes the examples shorter and easier to grasp.

The rest looks good to me.

@edmondchuc
Copy link
Contributor

I’m wondering if we should mention the restrictions on alternative paths in edit mode as described in #534 (comment), specifically on which predicate paths are allowed.

Should we also add a paragraph on the challenges of supporting complex paths in edit mode?

Otherwise, everything else looks good to me.

smessie and others added 2 commits October 14, 2025 13:18
Apply suggestions from code review

Co-authored-by: Thomas Bergwinkl <[email protected]>
@smessie
Copy link
Member Author

smessie commented Oct 14, 2025

@edmondchuc I’ve pushed a commit that addresses your comment. Is it what you had in mind, or are there specific things you’re missing, or is it too verbose? I’m open to suggestions.

@smessie smessie requested a review from bergos October 14, 2025 15:58
@bergos
Copy link
Contributor

bergos commented Oct 14, 2025

@smessie I think your last additions to alternative path and other complex paths are very useful.

One small thing: Can you add a shape to the Other Complex Paths example? I think it would be useful to show sh:path in that case.

@smessie
Copy link
Member Author

smessie commented Oct 20, 2025

@bergos I wasn't sure yet if a sequence path (sh:path ( ex:hasPart ex:hasPart ) ;) would maybe make more sense than the zero-or-more-path I've used now, but if you think it does, I can still change it.

@bergos
Copy link
Contributor

bergos commented Oct 20, 2025

@smessie not required to change anything. The path is fine like it is.

@TallTed
Copy link
Member

TallTed commented Oct 28, 2025

Screenshots may still be overly ambitious, but wireframes may be helpful to comprehension.

@smessie smessie merged commit 999f836 into gh-pages Oct 30, 2025
1 check passed
@smessie smessie deleted the issue-534-ui-property-paths branch October 30, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI For SHACL 1.2 UI spec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants