Skip to content

Issue 163 path #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: gh-pages
Choose a base branch
from
Open

Issue 163 path #620

wants to merge 13 commits into from

Conversation

@VladimirAlexiev
Copy link
Contributor

@VladimirAlexiev VladimirAlexiev commented Oct 23, 2025 •
edited
Loading

Closes #163

  • See this document rendered online here
  • @HolgerKnublauch Sorry, I made a github mistake and this includes a gazillion commits. Can you pick only the last one 8d3d823 ?
  • I've deleted a few duplicated words from a definition and replaced with a reference to the section that defines "substitution" fully.
  • Added suggestion to emit "BAD-PATH"
  • Added some words in Security as per @afs

VladimirAlexiev and others added 13 commits August 5, 2025 10:22
@VladimirAlexiev
minor editorial change
5498be5
@VladimirAlexiev
plantuml version of diagram
8243c01
@VladimirAlexiev
add manual <color> and <u> tags to class names
3de3e44
@VladimirAlexiev
add manual <color> and <u> tags to class names
01b4b1b
@VladimirAlexiev @YoucTagh
Update shacl12-core/images/SHACL-UML.puml
138b174 
Co-authored-by: Yousouf Taghzouti <[email protected]>
@VladimirAlexiev @YoucTagh
Update shacl12-core/images/SHACL-UML.puml
b991942 
Co-authored-by: Yousouf Taghzouti <[email protected]>
@VladimirAlexiev
- sh:order: xsd:integer or xsd:decimal
72e0ff6 
- sh:path : predicate or list or blank node and link to #property-paths
- add ellipsis as per TallTed
- rdf:List -> "list" because SHACL doesn't require the rdf:List type
- add sh:nodeKind, sh:ignoredProperties
@VladimirAlexiev
add <color:blue><u> to PropertyGroup
1ef8993
@VladimirAlexiev
replace textual diagram with PlantUML SVG diagram
01fe8a2
@VladimirAlexiev
replace <img> with script that embeds SVG content
367e5a1
@VladimirAlexiev
add core-components-list (3 fields), sh:targetWhere, sh:codeIdentifie…
2c4f8b4 
…r. Move sh:path to top of PropertyShape
@VladimirAlexiev
restore link to PropertyGroup
2770f32
@VladimirAlexiev
fixes w3c#163
8d3d823
@afs
Copy link
Contributor

afs commented Oct 23, 2025 •
edited
Loading

a github mistake and this includes a gazillion commits.

PRs are merged, not single commits from a PR.

You can get the commit with, for example, git show 8d3d823 > F, then create a clean, up-to-date branch, git apply F and submit a PR with the required changes.

HolgerKnublauch
HolgerKnublauch requested changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@HolgerKnublauch HolgerKnublauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I am afraid the best way forward would be for you to either create a new PR with just the change that you want, or roll back the unneeded parts here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HolgerKnublauch HolgerKnublauch HolgerKnublauch requested changes

@afs afs Awaiting requested review from afs

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clarify the use of $PATH, or string interpolation of SHACL paths

3 participants

@VladimirAlexiev @afs @HolgerKnublauch