Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: enable markdown shorthands in index.bs #166

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented May 2, 2024

@marcoscaceres
Copy link
Member Author

Merging this one, as it's need it for the other PRs I'm working on.

@marcoscaceres marcoscaceres merged commit 41a27ec into main May 2, 2024
2 checks passed
@marcoscaceres marcoscaceres deleted the enable_markdown branch May 2, 2024 08:32
github-actions bot added a commit that referenced this pull request May 2, 2024
SHA: 41a27ec
Reason: push, by marcoscaceres

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@reillyeon
Copy link
Member

LGTM but we should really turn on branch protection rules so that even editors like us need to get reviews before landing changes in the specification. I don't have access to those settings but I believe @himorin does.

@himorin
Copy link
Contributor

himorin commented May 7, 2024

@reillyeon removed that requirement (require PR stays). I suppose review requirement was placed by @marcoscaceres , so let me check if he want to keep it with adding editors(/chairs?) to Allow specified actors to bypass required pull requests, or something other method. both github team and individual account could be listed, so we may list -chairs team to there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants