Update names of referenced XPath functions and operators. #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In defining SPARQL functions, we often say "This function is the same as" and link to an XPath definition. However, several of the XPath functions are misnamed in this linking. This PR fixes the function and operator names for: * `fn:numeric-equal` -> `op:numeric-equal` * `fn:numeric-abs` -> `fn:abs` * `fn:numeric-round` -> `fn:round` * `fn:numeric-ceil` -> `fn:ceiling` * `fn:numeric-floor` -> `fn:floor`
rubensworks
approved these changes
Oct 31, 2025
Contributor
|
I checked Section 17 says https://www.w3.org/TR/sparql12-query/#expressions
See suggestion. |
afs
requested changes
Nov 1, 2025
| functions are invoked by name (an IRI) within a SPARQL query. For example:</p> | ||
| <pre class="query nohighlight"> | ||
| ... FILTER ( xsd:dateTime(?date) < xsd:dateTime("2005-01-01T00:00:00Z") ) ...</pre> | ||
| <p>Typographical convention in this section: XPath operators are labeled with the prefix |
Contributor
There was a problem hiding this comment.
Suggested change
| <p>Typographical convention: XPath operators are labeled with the prefix |
Contributor
There was a problem hiding this comment.
(hmm - looks bad but it is a long way from the PR chnages and also the github UI was struggling when dealing with the whole file.)
s/Typographical convention in this section:/Typographical convention:/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In defining SPARQL functions, we often say "This function is the same as" and link to an XPath definition. However, several of the XPath functions are misnamed in this linking. This PR fixes the function and operator names for:
fn:numeric-equal->op:numeric-equalfn:numeric-abs->fn:absfn:numeric-round->fn:roundfn:numeric-ceil->fn:ceilingfn:numeric-floor->fn:floorPreview | Diff