Skip to content

Update term "contrast ratio" for SC 1.4.11 #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions guidelines/terms/20/contrast-ratio.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,20 @@

<p class="note">Contrast ratios can range from 1 to 21 (commonly written 1:1 to 21:1).</p>

<p class="note">Because authors do not have control over user settings as to how text is rendered
(for example font smoothing or anti-aliasing), the contrast ratio for text can be
<p class="note">Because authors do not have control over user settings as to how text and non-text content is rendered
(for example font smoothing or anti-aliasing), the contrast ratio can be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(for example font smoothing or anti-aliasing), the contrast ratio can be
(for example font smoothing or anti-aliasing), the contrast ratio should be

evaluated with anti-aliasing turned off.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while the sentiment/idea is valid - that it's not just text but also non-text content, it's not possible to turn off anti-aliaising for things like SVG or CSS lines etc. And even for text, it's not always possible - depending on OS or user agent - to turn it off even for text rendering.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of just "with anti-aliasing turned off", this may need to be expanded to something like

Suggested change
evaluated with anti-aliasing turned off.
evaluated with anti-aliasing turned off or ignored.

</p>

<p class="note">For the purpose of Success Criteria 1.4.3 and 1.4.6, contrast is measured with respect
to the specified background over which the text is rendered in normal usage. If no
background color is specified, then white is assumed.
to the specified background over which the content is rendered in normal usage. If no
background color is specified, then white is assumed. If no
foreground color is specified, then black is assumed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as 1.4.3 and 1.4.6 are specifically about text, there's no sense here changing things to be more generic

</p>

<p class="note">Background color is the specified color of content over which the text is to be rendered
in normal usage. It is a failure if no background color is specified when the text
<p class="note">It is a failure if no background color is specified when the foreground
color is specified, because the user's default background color is unknown and cannot
be evaluated for sufficient contrast. For the same reason, it is a failure if no text
be evaluated for sufficient contrast. For the same reason, it is a failure if no foreground
color is specified when a background color is specified.
</p>

Expand Down