-
Notifications
You must be signed in to change notification settings - Fork 293
Add security mention to Timing Adjustable and tweak Re-Authentication #4382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
patrickhlauke
wants to merge
19
commits into
main
Choose a base branch
from
patrickhlauke-issue1424
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
88708ef
Replace strong paragraph with actual heading markup
patrickhlauke e03f966
Remove excessive whitespace
patrickhlauke 21d23f0
Add SC names to links
patrickhlauke cd523ad
Replace "spasticity"
patrickhlauke b0d9429
No need for parentheses
patrickhlauke 7ef6fe4
The notes aren't just about "server" time limits - generalise heading
patrickhlauke e7def26
Add note about exemption for security
patrickhlauke 11a06e7
Remove excessive whitespace
patrickhlauke ef0b25e
Modify reauthentication examples
patrickhlauke 3db7701
Add note/cross reference from re-authentication to timing adjustable
patrickhlauke 452056d
Update understanding/20/timing-adjustable.html
patrickhlauke a3f81b8
Merge branch 'main' into patrickhlauke-issue1424
patrickhlauke c023fa2
Merge branch 'main' into patrickhlauke-issue1424
patrickhlauke 35e9b3b
Update understanding/20/re-authenticating.html
patrickhlauke fa9f2b7
Update understanding/20/re-authenticating.html
patrickhlauke 01695c3
Update understanding/20/re-authenticating.html
patrickhlauke a3148a5
Update understanding/20/timing-adjustable.html
patrickhlauke 9f679d0
Update understanding/20/timing-adjustable.html
patrickhlauke 38322bb
Update understanding/20/timing-adjustable.html
patrickhlauke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like there was a possible intention in the original that although this timed out after 15 minutes, the javascript function at the end of this long list of features was intended to allow it to pass due to the "adjust" method (although as written it doesn't).
My feeling is that we've got a LOT of detritus now, when the only thing the author needs to do is set it to time out after 20 hours. The rest is superfluous and risks confusing what is required.
Does it make any sense to trim it down?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, there isn't even a requirement to inform the user of the time out, so just the first sentence without the next 2 would exceed what is necessary.