Fix note structure in abbreviation definition #4452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mbgower
added
ErratumRaised
bruce-usab
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4436.
This fixes the markup for the first top-level note in the abbreviations definition to use a
div, so that it can properly wrap the ordered list that is supposed to exist inside of it (as it did in WCAG 2.0).This also relegates the nested note to an inline annotation in a paragraph (suggested by Alastair), to avoid needing to worry about an unimplemented nesting edge case.
The diff will be easier to view with whitespace ignored (
?w=1).@netlify /guidelines/#dfn-abbreviations