[Framework] Move filtering menus generation logic #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filtering menus of the implementation column are now generated by the `generate.js` script. This means that the `filter-implstatus.js` script: 1. stays agnostic about browsers that it needs to filter. The script merely uses the info in the filtering menus and does not need to hardcode a precise list of browsers. 2. no longer needs to load translation files, which thus do not need to be kept around in published snapshots. The `generate-utils.js` and `utils.js` scripts have been kept separated for now to ease review but they can be merged again afterwards. The update also adds the possibility to provide translations of "desktop" and "mobile" in the tooltip.
xfq
reviewed
Apr 17, 2018
| padding: 0 0.1em; | ||
| text-align: left; | ||
| } | ||
|
|
||
| [data-col|=impl] details.active { |
There was a problem hiding this comment.
Why not just use [data-col=impl] here? (Same question for |= usages elsewhere.)
There was a problem hiding this comment.
There are two types of implementation columns: "Current implementations" and "Implementation intents". Internally, the data-col value for the former column is impl and the value for the latter is impl-intents. Styles need to apply to both columns, and that's precisely what the att|=val selector allows here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #216 to keep dependencies minimal in published snapshots.
The filtering menus of the implementation column are now generated by the
generate.jsscript. This means that thefilter-implstatus.jsscript:The
generate-utils.jsandutils.jsscripts have been kept separated for now to ease review but they can be merged again afterwards.The update also adds the possibility to provide translations of "desktop" and "mobile" in the tooltip.