[Framework] Localize date strings in pages #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last modified dates and publication dates were always formatted in English. They should now be formatted according to the language of the page. Under the hoods, the `toLocaleDateString` method gets used to format the date. Note browsers may only support a subset of locale settings in practice (and may for instance only support locale settings that are actually local to the user), so that mechanism may not always work. In particular, JSDOM, used to generate all roadmap pages in batch, does not seem to support Chinese, so rules for Chinese are hardcoded if JSDOM is detected. This commit is a fix for: w3c#213 (comment)
|
LGTM. We can also switch to intl (which implements ECMA-402) if we would like to support more languages/locales. Merging. |
Zirro
reviewed
May 3, 2018
| */ | ||
| const formatMonthAndYearDate = function (date, lang) { | ||
| if (((lang === 'zh') || lang.startsWith('zh-')) && | ||
| window._runScripts && window._virtualConsole && (window.name === 'nodejs')) { |
There was a problem hiding this comment.
I figured I should note that window.name === 'nodejs' is not supported as a way to detect jsdom, and is planned for removal in the next major version: jsdom/jsdom#2069
While no changes are planned to them at the moment, the properties starting with _ are also not part of the public API and could change in any version. The recommended way to detect jsdom is to inspect the user agent string instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last modified dates and publication dates were always formatted in English. They should now be formatted according to the language of the page.
Under the hoods, the
toLocaleDateStringmethod gets used to format the date. Note browsers may only support a subset of locale settings in practice (and may for instance only support locale settings that are actually local to the user), so that mechanism may not always work.In particular, JSDOM, used to generate all roadmap pages in batch, does not seem to support Chinese, so rules for Chinese are hardcoded if JSDOM is detected.
This commit is a fix for:
#213 (comment)