Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish definitions of credential key pair, private/public key #1226

Merged
merged 4 commits into from
Jun 7, 2019
Merged

Polish definitions of credential key pair, private/public key #1226

merged 4 commits into from
Jun 7, 2019

Conversation

emlun
Copy link
Member

@emlun emlun commented May 31, 2019 •
edited by pr-preview bot
Loading

Fixes #1122

  • Elaborate that a credential private key is expected to never leave the authenticator
  • Pull definitions of Credential Key Pair and Credential Private Key up to top level of Terminology section

Preview | Diff

@emlun emlun added this to the L2-WD-02 milestone May 31, 2019
@emlun emlun requested a review from equalsJeffH May 31, 2019 18:27
@emlun emlun self-assigned this May 31, 2019
@emlun
Copy link
Member Author

emlun commented Jun 5, 2019

This conflicts with issue #969.

equalsJeffH
equalsJeffH approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @emlun, LGTM, w/minor comment.

index.bs Outdated Show resolved Hide resolved
@emlun emlun merged commit bf594e1 into master Jun 7, 2019
@emlun emlun deleted the issue-1122-private-key branch June 7, 2019 13:47
WebAuthnBot pushed a commit that referenced this pull request Jun 7, 2019
Built by Travis-CI: bf594e1 Merge pull request #1226 from w3c/issue-1…
e68e2d7 
…122-private-key
WebAuthnBot pushed a commit that referenced this pull request Jun 7, 2019
Built by Travis-CI: bf594e1 Merge pull request #1226 from w3c/issue-1…
2b5027e 
…122-private-key
@emlun emlun mentioned this pull request Jun 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equalsJeffH equalsJeffH equalsJeffH approved these changes

Assignees

@emlun emlun

Labels
type:editorial
Projects
None yet
Milestone
L2-WD-02
Development

Successfully merging this pull request may close these issues.

spec is missing baseline posture that credential source is bound to a particular authenticator
2 participants
@emlun @equalsJeffH