Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace authData dfns under authData/ and flags under authData/flags/ #1771

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

emlun
Copy link
Member

@emlun emlun commented Jul 11, 2022

This is a step towards resolving #1740 and #1510, but I think it's substantive enough to warrant review on its own. This is a prerequisite of PR #1772, PR #1773 and PR #1774.

This repurposes the definitions of the UP and UV terms from referring to the abstract procedure to the corresponding authenticator data flags instead, because we were already using the terms only to refer to the flags. Also added are formal definitions for the other authData flags. These definitions along with those for other authData components are also moved into the authData/ namespace for better consistency with properties of other interfaces and dictionaries.

This will break some link anchors:

Anchor before Anchor after
#rpidhash #authdata-rpidhash
#flags #authdata-flags
#signcount #authdata-signcount
#attestedcredentialdata #authdata-attestedcredentialdata
#authdataextensions #authdata-extensions
#up #authdata-flags-up
#uv #authdata-flags-uv
#aaguid #authdata-attestedcredentialdata-aaguid
#credentialidlength #authdata-attestedcredentialdata-credentialidlength
#credentialid #authdata-attestedcredentialdata-credentialid
#credentialpublickey #authdata-attestedcredentialdata-credentialpublickey

Preview | Diff

@emlun
Copy link
Member Author

emlun commented Jul 26, 2022

PR #1663 adds a non-autolink reference to #aaguid which will need to be updated if this gets merged.

@nadalin nadalin added this to the L3-WD-01 milestone Jul 27, 2022
@emlun
Copy link
Member Author

emlun commented Aug 16, 2022

I missed the last meeting, but judging by the meeting minutes it seems @agl approves of merging this. I think that makes enough approvals, so I intend to go ahead and merge this after 2022-08-18T12:00 UTC. Please raise any objections before then (a simple "please wait" is enough).

@emlun emlun merged commit f754904 into main Aug 22, 2022
@emlun emlun deleted the flags-namespace branch August 22, 2022 12:39
github-actions bot added a commit that referenced this pull request Aug 22, 2022
SHA: f754904
Reason: push, by @emlun

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants