Proposal for sidePanel lifecycle events. #779
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial draft
Added the remaining sections.
Updated schema: - added PanelInfo - Removed reasons Removed un-asked use cases Elaborated on the workarounds Added points to the open discussions
Updated workarounds
Updated reasons in open discussions.
Fixed typos
Moved content from future work to Open discussions.
|
Related issue: #693 |
|
Gentle reminder for reviews on this @Rob--W, @oliverdunk, @xeenon. |
carlosjeurissen
added
the
topic: sidebar
oliverdunk
reviewed
May 15, 2025
| } | ||
| } | ||
| ``` | ||
| - Would adding onHidden, onShown or onVisibilityChanged events for side panel extensions make sense too? |
There was a problem hiding this comment.
As discussed in the last meeting, I am waiting until there is more discussion in the proposal about this before doing a full review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a proposal for the extensions sidePanel API events which will cater to basic lifecycle events like onClosed and onOpened.