Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch for ed/idl/SVG.idl #1488

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Add patch for ed/idl/SVG.idl #1488

merged 1 commit into from
Mar 6, 2025

Conversation

tidoust
Copy link
Member

@tidoust tidoust commented Mar 6, 2025

Second try (see #1487)

Fix IDL of SVG spec
@tidoust tidoust requested a review from dontcallmedom March 6, 2025 15:34
@dontcallmedom
Copy link
Member

thinking some more: we probably need an issue on this repo to reference in the patch, otherwise the patch will be deleted if the other SVG issue gets closed (one can always dream)

@tidoust
Copy link
Member Author

tidoust commented Mar 6, 2025

thinking some more: we probably need an issue on this repo to reference in the patch, otherwise the patch will be deleted if the other SVG issue gets closed (one can always dream)

Probably, but I'm going to lazily ignore the comment. Even if the other SVG issue gets fixed:

  1. Curation is going to fail immediately, most likely before the clean up job runs. We'll know that the patch needs an update.
  2. The clean up job won't delete the file in any case, it will just create a PR to delete it, and the PR won't pass IDL tests.

@tidoust tidoust merged commit 8cf9c1b into main Mar 6, 2025
1 check passed
@tidoust tidoust deleted the patch-20250306153305428 branch March 6, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants