Skip to content

Remove files no longer referenced #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Remove files no longer referenced #1508

merged 1 commit into from
Mar 26, 2025

Conversation

github-actions[bot]
Copy link
Contributor

This removes previously extracted files that are no longer referenced in browser-specs

Copy link
Member

@dontcallmedom dontcallmedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what do with this - on the one hand, it will remain in the curated package no matter what thanks to the freezepatch; on the other hand, the only reason to remove it from main is that our "remove file" job will keep insisting on it until the spec is fixed

@tidoust
Copy link
Member

tidoust commented Mar 26, 2025

Ah yes, I hadn't thought about that...

We added a "manual removal" mechanism to avoid running into situations where an extract would come and go with every crawl due to transient network errors or short-lived spec hiccups. The need to use a "freeze" patch should signal that the problem is not a pure transient error. I think it's fine to remove the file from the main branch in such cases while the underlying problem gets fixed. That would bring us closer to the "raw truth" that the main branch represents: there's no way to get this IDL extract from the spec for now.

@dontcallmedom
Copy link
Member

thanks, that sounds like a good principle to follow, indeed

@tidoust tidoust merged commit 07fee32 into main Mar 26, 2025
@tidoust tidoust deleted the cleanup-1742958931 branch March 26, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants