feat: Improve test coverage#17
Closed
hasibzero wants to merge 2 commits into
Closed
Conversation
This commit introduces a significant number of new tests to improve the overall test coverage of the repository. - Added a new test file `tests/test_logger.py` to cover the `checkcrontab/logger.py` module. This includes tests for the `ColoredFormatter` class, including its Windows-specific color compatibility logic, and the `setup_logging` function. - Added numerous new test cases to `tests/test_checker.py` to cover previously untested logic and edge cases in the `checkcrontab/checker.py` module. This includes tests for: - `check_filename` with `None` input. - `check_kind` with special file types (char device, block device, socket, fifo). - `validate_time_field_logic` with various invalid inputs. - `check_line` with insufficient fields, too many fields, and environment variables. - `check_minutes`, `check_hours`, `check_day_of_month`, `check_month`, and `check_day_of_week` with invalid formats. - `check_user` with various invalid formats. - `check_special` with an invalid keyword. - `check_dangerous_commands`. These changes increase the test coverage and improve the robustness of the codebase.
Improve test coverage
Owner
|
Hi @hasibzero |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.