Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC-68: User Authentication and Access Request System #49

Merged
merged 17 commits into from
Mar 31, 2025
Merged

Conversation

PivtoranisV
Copy link
Collaborator

@PivtoranisV PivtoranisV commented Mar 21, 2025

PC-68 Powered by Pull Request Badge

Hello Team, please review PR

Description

  • Create Login page using Device
  • Added styles and layout to make it match Figma design
  • Implement Forgot password? & "request here" mailto links
  • Add functionality for password visibility toggling (Used JavaScript for this)

Examples

Desktop (1440px)
Screenshot 2025-03-26 at 12 41 25
Tablet (768px)
Screenshot 2025-03-26 at 12 41 47
Mobile (375px)
Screenshot 2025-03-26 at 12 42 06

@PivtoranisV PivtoranisV added the work in progress Branch is not yet ready for code reviews or QA testing label Mar 21, 2025
@PivtoranisV PivtoranisV self-assigned this Mar 21, 2025
@rogergraves rogergraves temporarily deployed to clever-calculator-pr-49 March 21, 2025 14:49 Inactive
@PivtoranisV PivtoranisV temporarily deployed to clever-calculator-pr-49 March 21, 2025 18:10 Inactive
@PivtoranisV PivtoranisV temporarily deployed to clever-calculator-pr-49 March 23, 2025 23:14 Inactive
@PivtoranisV PivtoranisV temporarily deployed to clever-calculator-pr-49 March 24, 2025 08:59 Inactive
@PivtoranisV PivtoranisV temporarily deployed to clever-calculator-pr-49 March 24, 2025 10:32 Inactive
Base automatically changed from PC-59 to master March 24, 2025 15:27
@PivtoranisV PivtoranisV temporarily deployed to clever-calculator-pr-49 March 24, 2025 15:29 Inactive
@PivtoranisV PivtoranisV temporarily deployed to clever-calculator-pr-49 March 24, 2025 15:47 Inactive
@PivtoranisV PivtoranisV temporarily deployed to clever-calculator-pr-49 March 25, 2025 08:38 Inactive
@PivtoranisV PivtoranisV temporarily deployed to clever-calculator-pr-49 March 26, 2025 10:19 Inactive
@PivtoranisV PivtoranisV temporarily deployed to clever-calculator-pr-49 March 26, 2025 10:28 Inactive
@PivtoranisV PivtoranisV added review needed Code reviews needed by the minimum number of developers required and removed work in progress Branch is not yet ready for code reviews or QA testing labels Mar 26, 2025
Copy link
Contributor

@rogergraves rogergraves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the app/assets/images/logo.png we've decided to leave it as is, and then make it changeable (overridable) in ActiveAdmin.

@PivtoranisV
Copy link
Collaborator Author

On the app/assets/images/logo.png we've decided to leave it as is, and then make it changeable (overridable) in ActiveAdmin.

Hi @rogergraves, would you like me to add logic to ActiveAdmin to make logo changeable in this PR?
Or here I will just update to logo placeholder for now, and for ActiveAdmin we will have separate story in Jira?

@Maryna-Harasko
Copy link
Contributor

On the app/assets/images/logo.png we've decided to leave it as is, and then make it changeable (overridable) in ActiveAdmin.
@rogergraves I think we could create a separate story for this later. If we have enough time, we could also add the ability to manage the main colors and styles through ActiveAdmin, as Ron suggested. What do you think?

@rogergraves
Copy link
Contributor

@rogergraves I think we could create a separate story for this later. If we have enough time, we could also add the ability to manage the main colors and styles through ActiveAdmin, as Ron suggested. What do you think?

@PivtoranisV @Maryna-Harasko for sure let's deal with this in another story later, and not in this PR.

@rogergraves rogergraves added the merge conflicts A developer needs to resolve current merge conflicts label Mar 26, 2025
@PivtoranisV PivtoranisV temporarily deployed to clever-calculator-pr-49 March 26, 2025 14:54 Inactive
@PivtoranisV
Copy link
Collaborator Author

@PivtoranisV @Maryna-Harasko for sure let's deal with this in another story later, and not in this PR.

Cool, thank you! I just updated logo to placeholder, so we will remember to update it in near future to manage it in ActiveAdmin

@PivtoranisV PivtoranisV removed the merge conflicts A developer needs to resolve current merge conflicts label Mar 26, 2025
@rogergraves rogergraves added review done Code reviews are completed by the minimum number of developers required ready for testing Ready for QA to test locally or on a test server and removed review needed Code reviews needed by the minimum number of developers required labels Mar 26, 2025
@rezvaya13 rezvaya13 added in testing The QA team is testing this branch and removed ready for testing Ready for QA to test locally or on a test server labels Mar 27, 2025
@PivtoranisV PivtoranisV temporarily deployed to clever-calculator-pr-49 March 27, 2025 13:32 Inactive
@PivtoranisV PivtoranisV temporarily deployed to clever-calculator-pr-49 March 27, 2025 14:57 Inactive
@PivtoranisV PivtoranisV temporarily deployed to clever-calculator-pr-49 March 28, 2025 11:18 Inactive
@PivtoranisV PivtoranisV temporarily deployed to clever-calculator-pr-49 March 28, 2025 14:05 Inactive
@rezvaya13 rezvaya13 added qa done QA completed testing successfully and removed in testing The QA team is testing this branch labels Mar 28, 2025
@Maryna-Harasko Maryna-Harasko merged commit 0f1fff6 into master Mar 31, 2025
4 checks passed
@PivtoranisV PivtoranisV deleted the PC-68 branch March 31, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa done QA completed testing successfully review done Code reviews are completed by the minimum number of developers required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants