Skip to content

Editor controls fixes #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barabanovro merged 2 commits into from
Mar 19, 2025
Merged

Editor controls fixes #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a37f55c
Editor controls fixes
melnikga Mar 18, 2025
f762742
Fixes
melnikga Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/Editor/EditorControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,10 @@ const EditorControls = ({
<RiLinksLine size={16} />
</Button>

<div className="xl:hidden block">
<div className="xl:block hidden max-w-36 2xl:max-w-full">
<ExampleSelector onExampleChange={onExampleChange} />
</div>
<div className="xl:block hidden">
<div className="xl:hidden block">
<MobileExampleSelector onExampleChange={onExampleChange} />
</div>
</div>
Expand Down
20 changes: 6 additions & 14 deletions components/Editor/ExampleSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,12 @@ const examplesOptions = Examples.Cairo.map((_, i) => ({
label: CairoExampleNames[i],
}))

function ExampleSelector({ onExampleChange }: Props) {
export function MobileExampleSelector({ onExampleChange }: Props) {
return (
<Select
onChange={onExampleChange}
options={examplesOptions}
defaultValue={examplesOptions[0]}
components={{
DropdownIndicator,
}}
Expand All @@ -45,32 +46,23 @@ function ExampleSelector({ onExampleChange }: Props) {
)
}

export default ExampleSelector

export function MobileExampleSelector({ onExampleChange }: Props) {
export function ExampleSelector({ onExampleChange }: Props) {
return (
<Select
onChange={onExampleChange}
options={examplesOptions}
defaultValue={examplesOptions[0]}
classNamePrefix="select"
placeholder={'Choose Cairo Example'}
menuPlacement="top"
isSearchable={false}
instanceId={useId()}
styles={{
placeholder: (baseStyles) => ({
...baseStyles,
color: '#4B5563',
':hover': {
color: '#111827',
},
whiteSpace: 'nowrap',
}),
}}
/>
)
}

export default ExampleSelector

const reactSelectStyles: StylesConfig<
SelectOption,
false,
Expand Down
2 changes: 1 addition & 1 deletion components/Editor/examples.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ ret;
}

export const CairoExampleNames = [
'Simple',
'Simple program',
'Variables & mutability',
// 'Type casting',
'Control flow',
Expand Down