fix(i18n): replace placeholder strings with real translations across 9 locales#259
Conversation
…ocales Sweeps missing.json placeholders: export dialog (titles/descriptions/progress labels/format descriptions), reverse-conform dialog, timeline header tooltips, filler/silence removal toasts, keyframe editor, effects panel, media library, preview controls/monitor/zoom. Adds missing export.videoContainer.* keys that were previously surfacing as raw i18n keys. Translates all newly-fixed strings across es, fr, de, pt-BR, tr, ja, ko, zh.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR replaces machine-generated placeholder strings (e.g.,
Confidence Score: 3/5The The src/i18n/locales/partials/missing.json needs a pass over the Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[missing.json] --> B{Locale}
B --> EN[en]
B --> ES[es]
B --> FR[fr]
B --> DE[de]
B --> PTBR[pt-BR]
B --> TR[tr]
B --> JA[ja]
B --> KO[ko]
B --> ZH[zh]
EN --> EN1[checkmark export / effects / timeline.header / preview.controls]
EN --> EN2[cross media.embeddedSubtitles cuesCount / desc / trackInfo etc.]
EN --> EN3[cross media.picker.descAll / subtitleScan / transcribe.progressAria]
EN --> EN4[cross timeline.addAudioTrackHint / addVideoTrackHint]
ES --> ES1[checkmark All sections translated]
FR --> FR1[checkmark All sections translated]
DE --> DE1[checkmark All sections translated]
PTBR --> PTBR1[checkmark Most sections translated]
TR --> TR1[checkmark All sections translated]
JA --> JA1[checkmark All sections translated]
KO --> KO1[checkmark All sections translated]
ZH --> ZH1[checkmark All sections translated]
Prompt To Fix All With AIFix the following 3 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 3
src/i18n/locales/partials/missing.json:200-213
**Placeholder strings still present in `en` locale — `media.embeddedSubtitles`**
The `en` locale's `media.embeddedSubtitles` block still contains machine-generated placeholder values that were not replaced in this PR, while the equivalent keys were fully translated in `es`, `fr`, `de`, `ja`, `ko`, `zh` (e.g., `es` → `"cuesCount": "{{count}} líneas"`, `"desc": "Selecciona una pista de subtítulos…"`, `"trackInfo": "Pista {{n}} · {{lang}} · {{codec}}"`). The unchanged `en` keys include `cuesCount`, `desc`, `descForFile`, `empty`, `insert`, `insertWithCues`, `loadedFromCache`, `scanning`, and `trackInfo` — any user running in English will see these raw key-fragment strings in the embedded-subtitles panel.
### Issue 2 of 3
src/i18n/locales/partials/missing.json:350-372
**Additional `en` locale placeholder strings missed in `media` section**
Several more keys in the `en` locale block were not updated while every other locale received real copy: `media.picker.descAll` is still `"Description All"` (line 351), `media.subtitleScan.descComplete` is `"Description Complete"` (line 360), `media.subtitleScan.descScanning` is `"Description Scanning"` (line 361), and `media.transcribe.progressAria` is `"Progress ARIA"` (line 372). The Spanish equivalents, for example, are `"Elige un archivo de la biblioteca del proyecto."`, `"Búsqueda de subtítulos completada."`, `"Buscando subtítulos en tus medios…"`, and `"Progreso de la transcripción"` respectively.
### Issue 3 of 3
src/i18n/locales/partials/missing.json:455-457
**`en` locale `timeline.addAudioTrackHint` and `timeline.addVideoTrackHint` still placeholders**
Both `"addAudioTrackHint": "Add Audio Track Hint"` and `"addVideoTrackHint": "Add Video Track Hint"` are unchanged title-cased placeholder fragments in the `en` locale. Other locales have either kept similar machine-generated forms or translated them properly. Since these hint strings appear in the timeline header, English-speaking users will see raw key-fragment text as UI copy.
Reviews (1): Last reviewed commit: "fix(i18n): replace placeholders with rea..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| @@ -203,14 +209,14 @@ | |||
| "insertWithCues": "Insert With Cues", | |||
| "loadedFromCache": "Loaded From Cache", | |||
| "scanning": "Scanning", | |||
| "title": "Title", | |||
| "title": "Embedded subtitles", | |||
| "trackInfo": "Track Info" | |||
There was a problem hiding this comment.
en locale — media.embeddedSubtitles
The en locale's media.embeddedSubtitles block still contains machine-generated placeholder values that were not replaced in this PR, while the equivalent keys were fully translated in es, fr, de, ja, ko, zh (e.g., es → "cuesCount": "{{count}} líneas", "desc": "Selecciona una pista de subtítulos…", "trackInfo": "Pista {{n}} · {{lang}} · {{codec}}"). The unchanged en keys include cuesCount, desc, descForFile, empty, insert, insertWithCues, loadedFromCache, scanning, and trackInfo — any user running in English will see these raw key-fragment strings in the embedded-subtitles panel.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/i18n/locales/partials/missing.json
Line: 200-213
Comment:
**Placeholder strings still present in `en` locale — `media.embeddedSubtitles`**
The `en` locale's `media.embeddedSubtitles` block still contains machine-generated placeholder values that were not replaced in this PR, while the equivalent keys were fully translated in `es`, `fr`, `de`, `ja`, `ko`, `zh` (e.g., `es` → `"cuesCount": "{{count}} líneas"`, `"desc": "Selecciona una pista de subtítulos…"`, `"trackInfo": "Pista {{n}} · {{lang}} · {{codec}}"`). The unchanged `en` keys include `cuesCount`, `desc`, `descForFile`, `empty`, `insert`, `insertWithCues`, `loadedFromCache`, `scanning`, and `trackInfo` — any user running in English will see these raw key-fragment strings in the embedded-subtitles panel.
How can I resolve this? If you propose a fix, please make it concise.
| "picker": { | ||
| "descAll": "Description All", | ||
| "noFiles": "No Files", | ||
| "noFiles": "No media in this project yet.", | ||
| "noSearchResults": "No Search Results", | ||
| "title": "Title" | ||
| "title": "Choose media" | ||
| }, | ||
| "searchMedia": "Search Media", | ||
| "subtitleScan": { | ||
| "cached": "Cached", | ||
| "cancelBatch": "Cancel Batch", | ||
| "cancelBatch": "Cancel all", | ||
| "descComplete": "Description Complete", | ||
| "descScanning": "Description Scanning", | ||
| "failed": "Failed", | ||
| "titleComplete": "Title Complete", | ||
| "titleScanning": "Title Scanning" | ||
| "titleComplete": "Subtitle scan complete", | ||
| "titleScanning": "Scanning for subtitles…" | ||
| }, | ||
| "transcribe": { | ||
| "autoDetect": "Auto Detect", | ||
| "generateTitle": "Generate Title", | ||
| "generateTitle": "Generate transcript", | ||
| "language": "Language", | ||
| "model": "Model", | ||
| "noLanguages": "No Languages", | ||
| "progressAria": "Progress ARIA", |
There was a problem hiding this comment.
en locale placeholder strings missed in media section
Several more keys in the en locale block were not updated while every other locale received real copy: media.picker.descAll is still "Description All" (line 351), media.subtitleScan.descComplete is "Description Complete" (line 360), media.subtitleScan.descScanning is "Description Scanning" (line 361), and media.transcribe.progressAria is "Progress ARIA" (line 372). The Spanish equivalents, for example, are "Elige un archivo de la biblioteca del proyecto.", "Búsqueda de subtítulos completada.", "Buscando subtítulos en tus medios…", and "Progreso de la transcripción" respectively.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/i18n/locales/partials/missing.json
Line: 350-372
Comment:
**Additional `en` locale placeholder strings missed in `media` section**
Several more keys in the `en` locale block were not updated while every other locale received real copy: `media.picker.descAll` is still `"Description All"` (line 351), `media.subtitleScan.descComplete` is `"Description Complete"` (line 360), `media.subtitleScan.descScanning` is `"Description Scanning"` (line 361), and `media.transcribe.progressAria` is `"Progress ARIA"` (line 372). The Spanish equivalents, for example, are `"Elige un archivo de la biblioteca del proyecto."`, `"Búsqueda de subtítulos completada."`, `"Buscando subtítulos en tus medios…"`, and `"Progreso de la transcripción"` respectively.
How can I resolve this? If you propose a fix, please make it concise.| "timeline": { | ||
| "addAudioTrackHint": "Add Audio Track Hint", | ||
| "addVideoTrackHint": "Add Video Track Hint", |
There was a problem hiding this comment.
en locale timeline.addAudioTrackHint and timeline.addVideoTrackHint still placeholders
Both "addAudioTrackHint": "Add Audio Track Hint" and "addVideoTrackHint": "Add Video Track Hint" are unchanged title-cased placeholder fragments in the en locale. Other locales have either kept similar machine-generated forms or translated them properly. Since these hint strings appear in the timeline header, English-speaking users will see raw key-fragment text as UI copy.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/i18n/locales/partials/missing.json
Line: 455-457
Comment:
**`en` locale `timeline.addAudioTrackHint` and `timeline.addVideoTrackHint` still placeholders**
Both `"addAudioTrackHint": "Add Audio Track Hint"` and `"addVideoTrackHint": "Add Video Track Hint"` are unchanged title-cased placeholder fragments in the `en` locale. Other locales have either kept similar machine-generated forms or translated them properly. Since these hint strings appear in the timeline header, English-speaking users will see raw key-fragment text as UI copy.
How can I resolve this? If you propose a fix, please make it concise.1 participant
Summary
\"Title Settings\",\"Frames Label\",\"Toast No Removable\") with real user-facing copy.export.videoContainer.{mp4,mov,webm,mkv}keys that were surfacing as raw i18n keys in the export dialog.en,es,fr,de,pt-BR,tr,ja,ko,zh.Scope covers: export dialog (settings/progress/complete/error/cancelled states + format descriptions), reverse-conform dialog, timeline header toolbar, filler/silence removal panels, keyframe editor, effects panel, preview controls/monitor/zoom/stage/player/align, media library/card/info/picker/grid/transcribe/embedded-subtitles/orphaned-clips/unsupported-codec.
Single-file change:
src/i18n/locales/partials/missing.json(+2143 / -2089).Test plan
es/fr/de/pt-BR/tr/ja/ko/zhand re-verify the above — no raw English fallback in the user-facing strings touched by this PR.