[WIP] Refactor #9
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiggleLiu
reviewed
Mar 5, 2025
.vscode/settings.json
Outdated
There was a problem hiding this comment.
Please remove this file.
src/NCTSSOS.jl
Outdated
| export PolynomialOptimizationProblem | ||
|
|
||
| include("moment_solver.jl") | ||
| export MomentMethod, init_moment_vector!, constrain_moment_matrix!, make_sdp, set_total_basis2var_dict!, get_total_basis2var_dict |
There was a problem hiding this comment.
Do not export API unless this is very nessesary.
There was a problem hiding this comment.
Move export lines together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
NCTSSOSproject, focusing on restructuring the codebase, introducing new functionalities, and adding comprehensive tests. The most important changes include the reorganization of module imports, the introduction of new types and methods for polynomial optimization problems, and the addition of extensive test cases.Reorganization and Module Imports:
src/NCTSSOS.jl: Reorganized module imports, removing unused ones and consolidating includes and exports.New Types and Methods:
src/moment_solver.jl: IntroducedMomentMethodtype and related methods for handling moment matrices in optimization problems.src/pop.jl: AddedPolynomialOptimizationProblemtype and associated methods for defining and manipulating polynomial optimization problems.src/solver_utils.jl: Implemented utility functions such asremove_zero_degree,star, andsymmetric_canonicalizefor handling polynomial variables and monomials.src/sos_solver.jl: Addeddualizemethod for creating dual optimization models.Testing Enhancements:
test/moment_solver.jl: Added test cases forMomentMethodand its methods, including initialization and example usage.test/pop.jl: Introduced tests forPolynomialOptimizationProblemto verify the correctness of variable and constraint handling.test/solver_utils.jl: Added tests for utility functions to ensure proper manipulation of polynomial variables and monomials.test/sos_solver.jl: Included tests for thedualizemethod to validate dual model creation and optimization.These changes collectively enhance the functionality, maintainability, and test coverage of the
NCTSSOSproject.