Fix prototype mismatch in private-network.h - #3027
Closed
Dolphindalt wants to merge 1 commit into
Closed
Conversation
Member
|
This was a bit confusing... main does not look like how you described. In fact I solved this in 2020 the other way, by just using the enum for everything. It happened long enough ago, that on main branch, which is what the PR is trying to patch, and on v4.3-stable, there's no need for this patch. And anything else is too old to worry about. So you should probably upgrade to at least v4.3-stable. |
Author
|
I see. Thank you for the response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of
lws_tls_server_abort_connectionis defined as below.But in the header file, it is defined as the following.
Compiling with a aarch64-none-linux-gnu compiler, the following error is produced.
This error does not appear when compiling with arm-linux-gnueabihf compiler.
The proposed change simply updates the prototype in the header to match the body. This resolves the compilation issue.