Add telemetry to cloud handoff settings toggles#12100
Open
dplakon wants to merge 1 commit into
Open
Conversation
Fire FeaturesPageAction telemetry events when users toggle the Cloud Handoff, Ampersand Handoff, and Auto Handoff on Sleep settings, reporting the user-facing enabled state. Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
Adds FeaturesPageAction telemetry for the Cloud handoff, Ampersand handoff, and Auto-handoff before sleep settings toggles, reporting the user-facing enabled state after each toggle.
Concerns
- No blocking correctness, security, or spec-drift concerns found in the reviewed diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Port of warpdotdev/warp-internal#26149. Add
FeaturesPageActiontelemetry events to the Cloud Handoff, Ampersand Handoff, and Auto Handoff on Sleep settings toggles. When users toggle these settings, we now fire events with:action:"ToggleCloudHandoff","ToggleAmpersandHandoff", or"ToggleAutoHandoffOnSleep"value: the user-facing enabled stateThese events land in BigQuery as
featurespage.actioninstg_terminal_events.Linked Issue
N/A — instrumentation for auto-handoff rollout tracking.
Testing
cargo checkcompiles cleanlyNo new tests needed
Telemetry-only change adding
send_telemetry_from_ctx!calls inside existing toggle handlers, following the same pattern as other AI settings toggles.Agent Mode
Co-Authored-By: Oz oz-agent@warp.dev
CHANGELOG-NONE