Guard Mermaid rendering against dagre panics#12109
Draft
zachlloyd wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mermaid_to_svgto a commit that makesdagre_rust::intersect_recthandle degenerate center-point intersections without panicking.Upstream dependency PR: warpdotdev/mermaid-to-svg#16
No new log statements were added.
Linked Issue
N/A - Slack crash-cluster investigation from
#dev-crash-clusters.Testing
cargo fmt --manifest-path /workspace/warp/Cargo.toml --all --checkCARGO_BUILD_JOBS=1 cargo nextest run --manifest-path /workspace/warp/Cargo.toml --no-fail-fast --workspace mermaid_renderer_panic_returns_errorCARGO_BUILD_JOBS=1 cargo check --manifest-path /workspace/warp/Cargo.toml -p warp_editorCARGO_BUILD_JOBS=1 cargo clippy --manifest-path /workspace/warp/Cargo.toml -p warp_editor --no-depsI have manually tested my changes locally with
./script/runScreenshots / Videos
N/A - crash containment/dependency fix with automated coverage.
Agent Mode
CHANGELOG-BUG-FIX: Fixed a Mermaid rendering crash caused by degenerate Dagre edge intersections.
Conversation: https://staging.warp.dev/conversation/2381ce85-50ab-49ff-a15b-1f8d84dc3196
Run: https://oz.staging.warp.dev/runs/019e8a8d-7abf-793f-9859-6dbd1ac7de30
This PR was generated with Oz.