Split model and effort pickers#12120
Closed
jasonkeung wants to merge 1 commit into
Closed
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Splits noisy combined model/effort model pickers into separate base-model and effort-level controls.
model_id.base_model_nameandreasoning_level) for Warp/Oz models, with conservative display-name grouping for harness model metadata.Default modelandEffort leveldropdowns.Linked Issue
No GitHub issue; requested from Slack.
ready-to-specorready-to-implement.Testing
cargo check --manifest-path /workspace/warp/Cargo.toml -p onboarding -p warpcargo test --manifest-path /workspace/warp/Cargo.toml -p warp orchestration_controlscargo fmt --manifest-path /workspace/warp/app/Cargo.toml --checkcargo fmt --manifest-path /workspace/warp/crates/onboarding/Cargo.toml --checkcargo build --manifest-path /workspace/warp/Cargo.toml -p warp --bin warp-oss./script/runScreenshots / Videos
Manual visual validation was done by launching
/workspace/warp/target/debug/warp-ossand walking through onboarding. The "Customize your Warp Agent" screen showed separateDefault modelandEffort levelcontrols; the model dropdown grouped base models, and the effort dropdown showed the valid effort choices for the selected base model.I could not attach a saved screenshot from the sandbox because the available screenshot utilities/PIL dependencies were missing, but the UI was visually inspected through computer use after a successful build.
Agent Mode
CHANGELOG-OZ: Split Warp Agent model selection into separate model and effort level controls while preserving existing model IDs.
Conversation: https://staging.warp.dev/conversation/80bf636c-061f-46d5-9004-dbea4dcc3422
Run: https://oz.staging.warp.dev/runs/019e8b4d-585d-73ac-ab22-ca860bbc9b22
This PR was generated with Oz.