Include PS1 prompts when copying blocks#13076
Conversation
|
/oz-review |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR updates block copying so command-and-output copies include the visible PS1 prompt path while preserving Warp prompt behavior, and adds unit plus integration coverage for both enabled and disabled Honor PS1 modes.
Concerns
- No blocking correctness, security, or spec-alignment concerns found.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
There was a problem hiding this comment.
Overview
This PR updates block copy behavior so CommandAndOutput copies include the visible PS1 prompt/rprompt when PS1 prompt mode is enabled, while preserving the existing Warp prompt behavior. It also adds unit coverage for the block string conversion and integration coverage for both honor_ps1 states.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the changed lines.
- User-facing visual evidence is included in the PR description.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Description
When a user copies a block with a custom PS1 prompt, include the visible prompt text along with the command and output. Warp prompt mode keeps the previous behavior and copies only the command and output.
This revives the prompt-mode-gated behavior discussed in the now-closed #10181, with current unit and integration coverage.
Linked Issue
Closes #9123
ready-to-specorready-to-implement.Testing
cargo test -p warp test_command_and_output_to_string --libcargo run -p integration --bin integration -- test_copy_block_command_and_output_honor_ps1_disabledcargo run -p integration --bin integration -- test_copy_block_command_and_output_honor_ps1_enabledcargo test -p integration test_copy_block_command_and_output_honor_ps1 -- --nocapturegit diff --check./script/runcargo nextestis not installed on my local machine, so I validated the shell integration harness throughcargo test -p integration ...instead.Screenshots / Videos
Recorded integration test evidence for the PS1-enabled copy path:
Agent Mode
CHANGELOG-BUG-FIX: Include custom PS1 prompt text when copying terminal blocks.