Hide "New group with tab" on tabs that are already in a group#13081
Hide "New group with tab" on tabs that are already in a group#130812nd1st wants to merge 1 commit into
Conversation
The vertical-tab context menu offered "New group with tab" unconditionally, so selecting it on a tab that is already in a group spun it into a confusing one-member "New Group" that read as overwriting the current tab. Gate the item on self.group_id.is_none(), mirroring the sibling "Remove from group" item which is already gated on group membership. Regrouping a grouped tab stays reachable via drag / multi-select. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @2nd1st on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
Every PR must be linked to a same-repo issue before Oz can review it. This PR is linked to #13073, but no linked issue is marked See the contribution guidelines for the full readiness model. Powered by Oz |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
This PR is linked to #13073, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /oz-review to re-trigger review.
See the contribution guidelines for the full readiness model.
Powered by Oz
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Description
The vertical-tab context menu offered "New group with tab" unconditionally. On a tab that is already in a group, selecting it spun the tab into a confusing one-member "New Group" that read as overwriting the current tab. This gates the menu item on
self.group_id.is_none(), mirroring the sibling "Remove from group" item which is already gated on the tab being in a group. Regrouping a grouped tab stays reachable via drag / multi-select.(The grouped-tabs UI is behind the
GroupedTabsfeature flag.)Linked Issue
Fixes #13073
ready-to-specorready-to-implement.Testing
./script/runAdded a regression test —
app/src/tab_tests.rs(tab::tests::new_group_with_tab_hidden_when_tab_already_grouped): withGroupedTabsenabled it assertstab_group_menu_itemsomits "New group with tab" for a grouped tab and still offers it for an ungrouped tab. The grouped-tab assertion fails against the old unconditional code.Screenshots / Videos
Right-click context menu with
GroupedTabsenabled:Tab already in a group — the menu no longer offers "New group with tab" (only "Remove from group", etc.):
Ungrouped tab (for contrast) — still offers "New group with tab":
(Before this fix, the grouped-tab menu also offered "New group with tab" — see #13073.)
Agent Mode