Skip to content

Hide "New group with tab" on tabs that are already in a group#13081

Open
2nd1st wants to merge 1 commit into
warpdotdev:masterfrom
2nd1st:2nd1st/fix-new-group-with-tab
Open

Hide "New group with tab" on tabs that are already in a group#13081
2nd1st wants to merge 1 commit into
warpdotdev:masterfrom
2nd1st:2nd1st/fix-new-group-with-tab

Conversation

@2nd1st

@2nd1st 2nd1st commented Jun 26, 2026

Copy link
Copy Markdown

Description

The vertical-tab context menu offered "New group with tab" unconditionally. On a tab that is already in a group, selecting it spun the tab into a confusing one-member "New Group" that read as overwriting the current tab. This gates the menu item on self.group_id.is_none(), mirroring the sibling "Remove from group" item which is already gated on the tab being in a group. Regrouping a grouped tab stays reachable via drag / multi-select.

(The grouped-tabs UI is behind the GroupedTabs feature flag.)

Linked Issue

Fixes #13073

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Screenshots are included below.

Testing

  • I have manually tested my changes locally with ./script/run

Added a regression test — app/src/tab_tests.rs (tab::tests::new_group_with_tab_hidden_when_tab_already_grouped): with GroupedTabs enabled it asserts tab_group_menu_items omits "New group with tab" for a grouped tab and still offers it for an ungrouped tab. The grouped-tab assertion fails against the old unconditional code.

Screenshots / Videos

Right-click context menu with GroupedTabs enabled:

Tab already in a group — the menu no longer offers "New group with tab" (only "Remove from group", etc.):

Screenshot 2026-06-26 at 6 32 18 PM

Ungrouped tab (for contrast) — still offers "New group with tab":

Screenshot 2026-06-26 at 6 32 35 PM

(Before this fix, the grouped-tab menu also offered "New group with tab" — see #13073.)

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

The vertical-tab context menu offered "New group with tab" unconditionally, so selecting it on a tab that is already in a group spun it into a confusing one-member "New Group" that read as overwriting the current tab. Gate the item on self.group_id.is_none(), mirroring the sibling "Remove from group" item which is already gated on group membership. Regrouping a grouped tab stays reachable via drag / multi-select.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@cla-bot

cla-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @2nd1st on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

@oz-for-oss

oz-for-oss Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@2nd1st

Every PR must be linked to a same-repo issue before Oz can review it.

This PR is linked to #13073, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Jun 26, 2026

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@2nd1st

Every PR must be linked to a same-repo issue before Oz can review it.

This PR is linked to #13073, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

@2nd1st

2nd1st commented Jun 26, 2026

Copy link
Copy Markdown
Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed label Jun 26, 2026
@cla-bot

cla-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vertical tabs: "New group with tab" is offered on a tab that is already in a group

1 participant