Add Copy as Markdown for AI documents#13082
Conversation
github-actions
Bot
added
the
external-contributor
|
/oz-review |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
Adds a Copy as Markdown action to the AI document overflow menu, reusing the existing unescaped markdown serializer and adding unit/integration coverage for the clipboard output.
Concerns
- No blocking correctness, security, or spec-drift concerns found.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
There was a problem hiding this comment.
Overview
Adds a Copy as Markdown action to the AI document overflow menu, reusing the existing Markdown serialization path and covering the behavior with unit and integration tests.
Concerns
- Non-blocking: one user-facing toast string still says “Plan” while the new action is labeled for AI documents generally.
Verdict
Found: 0 critical, 0 important, 1 suggestions
Approve with nits
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| ToastStack::handle(ctx).update(ctx, |toast_stack, ctx| { | ||
| toast_stack.add_ephemeral_toast( | ||
| DismissibleToast::success( | ||
| "Plan copied to clipboard as Markdown".to_string(), |
There was a problem hiding this comment.
💡 [SUGGESTION] Keep the success toast aligned with the generic “AI document” menu action so non-plan documents do not read as plans.
| "Plan copied to clipboard as Markdown".to_string(), | |
| "AI document copied to clipboard as Markdown".to_string(), |
SkyNotSilent
force-pushed
the
codex/fix-9214-copy-plan-markdown
branch
from
35cfb11 to
d0fa75f
Compare
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds a Copy as Markdown action to the AI document overflow menu, reusing the same markdown_unescaped serialization path as Markdown export and showing a success toast after writing to the clipboard. It also adds focused model coverage for copyable Markdown structure and an integration test that exercises the overflow-menu clipboard flow.
Concerns
No blocking correctness, security, or spec-alignment concerns found. The PR includes visual evidence for the user-facing menu change.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
1 participant
Description
Adds a
Copy as Markdownaction to the AI document overflow menu. The action reuses the samemarkdown_unescapedserializer used by Markdown export, writes the result to the clipboard, and shows a success toast.Linked Issue
Closes #9214
ready-to-specorready-to-implement.Testing
./script/format --check./script/check_no_inline_test_modulescargo test -p warp test_plan_markdown_content_preserves_copyable_structure --libcargo run -p integration --bin integration -- test_copy_ai_document_as_markdown_from_overflow_menucargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warningscargo clippy -p warp_completer --all-targets --tests -- -D warnings./script/runScreenshots / Videos
Real-display integration run showing the AI document overflow menu action and clipboard assertion:
Agent Mode
CHANGELOG-IMPROVEMENT: Add a Copy as Markdown action to AI planning document menus.