Fix dyld libzstd error in distributed macOS binaries#102
Merged
Conversation
Users installing oitec on machines without Homebrew's zstd hit a dyld error because the binary had a dynamic dependency on libzstd.1.dylib. Fix by removing the .dylib files before building on both macOS targets, forcing the linker to use the static archive (libzstd.a) instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oitecon macOS without Homebrew's zstd hit adyld: Library not loaded: libzstd.1.dyliberror at runtimelibzstd.1.dylib, creating a runtime dependency that isn't present on end-user machines.dylibfiles before building on both macOS targets (aarch64 and x86_64), forcing the linker to uselibzstd.a(static archive) insteadChanges
libzstd*.dylibbefore build, setsLIBRARY_PATHandMACOSX_DEPLOYMENT_TARGET.dylibremoval; also removed explicit-lzstdlinker flag (redundant withLIBRARY_PATH)Test plan
otool -Lon the resulting macOS binaries shows no reference tolibzstd.1.dylib🤖 Generated with Claude Code