Fix unnecessary unwrap on potentially empty process vector#80
Open
prjanitor wants to merge 1 commit into
Open
Conversation
Add a check for empty a_procs before calling .last_mut().unwrap() in the Pipeline case of eval_command. When the left side of a pipeline produces no processes (e.g., due to an error in execute_simple_command), the previous code would panic at runtime. Now it returns early with an empty result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a panic that occurs in
eval_commandwhen handling Pipeline commands. The code was callinga_procs.last_mut().unwrap()without checking ifa_procsis empty.Problem
When the left side of a pipeline produces no processes (e.g., due to an error in
execute_simple_commandreturning an empty vector), the.unwrap()call causes a runtime panic.Solution
Added a check for
a_procs.is_empty()before accessing the last element. If empty, the function returns early with an empty result, preventing the panic.Testing
The fix handles the edge case where pipeline commands produce no processes, ensuring graceful degradation instead of a panic.
This PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.