-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(deploy): add custom-server-url option #3437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@hakkiai thank you for the contribution! Can you ask you to use the official PR template and fill it out: https://raw.githubusercontent.com/wasp-lang/wasp/refs/heads/main/.github/pull_request_template.md Someone from the team will review this soon :) |
|
Thanks @infomiho I’ve updated the PR to use the official template and filled everything out. |
|
@hakkiai great! Can I ask you to run Also, please add an entry to the |
|
Hi @infomiho, Thanks for pointing it out. I've now run Also added the missing entry to Just pushed the changes. |
|
Hey @hakkiai look at your latest commit: e991e5e, there were no formatting changes and the CI is still failing: https://github.com/wasp-lang/wasp/actions/runs/19700569960/job/56442249432?pr=3437 Please make sure you ran the I also noticed that you committed some of local helper |
|
Thanks for the review again @infomiho I've removed the I ran the Prettier formatter once more successfully. I had already run I also resolved the merge conflict in |
|
@hakkiai The CI is still failing on formatting, check it here and you'll see which files are not formatted: https://github.com/wasp-lang/wasp/actions/runs/19743464571/job/56632265983?pr=3437 once you run the Also, the |
|
Sorry for the back & forth changes @infomiho Actually prettier is running successfully for me, i ran it on the package where I made the updates, and it is reporting no changes, so I am not sure why CI is failing. This time to be 100% sure, I’ve now run npm run prettier:check on the whole project, and found formatting errors in deploy.ts while everything else stayed unchanged. pushed those changes. I also added the missing Everything should be green now hopefully. Thanks for your patience @infomiho |
|
@hakkiai Let's resolve the conflicts:
|
Description
Added a new
--custom-server-urloption to the deploy command for both Fly.io and Railway providers.This flag allows users to explicitly set the server URL that the client app should connect to.
It’s useful when deploying to a custom domain or when the inferred URL is incorrect (e.g., reverse proxy, custom routing).
The precedence for determining the server URL is now:
--custom-server-url(CLI)REACT_APP_API_URL(env var)This improves flexibility when deploying and makes custom-domain setups easier without relying solely on env variables.
Type of change
Checklist
🧪 Tests and apps:
📜 Documentation:
web/docs/if needed.🆕 Changelog:
I updated
waspc/ChangeLog.mdwith a user-friendly description of the change.I bumped the version in
waspc/waspc.cabalif required.Fixes Specify custom server URL via an explict option #3431