disable scaled_ylm_std() when using Apple Clang#156
Merged
Conversation
wavefunction91
requested changes
Oct 24, 2025
Owner
wavefunction91
left a comment
wavefunction91
left a comment
There was a problem hiding this comment.
Great! If possible, can you incorporate this into the PR pipeline rather than standing up a whole separate "on_push". I'm all for making sure I don't accidentally brick MacOS builds in the future :).
Contributor
Author
|
@wavefunction91 I moved the build to (hopefully) the right place. i think you'll need to trigger/approve the workflow run, but once you do i can help make sure we get it to green ... otherwise hopefully we are good to go! |
wavefunction91
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes build on macOS by wrapping
scaled_ylm_std()in#ifndef __APPLE__.this particular function looks unused/reference-only but calls
std::sph_legendrewhich doesn't exist in Apple'slibc++which causes build failures. shouldn't cause any weird side effects by disabling, but if so it'll be limited to macos :)to verify i added CI for ubuntu + macos and appears that the tests pass.
resolves #153