Remove duplicated HIGH-SIGNAL block in code-review, add a dup test#4
Merged
Merged
Conversation
The "Critical: only HIGH-SIGNAL issues should be flagged" block appeared twice, back to back, in code-review's SKILL.md and command. The second copy was a strict subset of the first (it dropped the "Concrete edge cases" bullet), so it was pure redundancy. The duplicate is removed; the complete first copy stays. The skill-lint suite gains a per-skill "no duplicated block" check (no non-empty line >= 50 chars repeats within a SKILL.md or its command), which catches this class of copy-paste error. SKILL.md and command stay in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
**Critical: only HIGH-SIGNAL issues should be flagged.**block appearedtwice, back to back, in
code-review'sSKILL.mdand command. The second copywas a strict subset of the first (it dropped the "Concrete edge cases" bullet),
so it was pure redundancy. The duplicate is removed; the complete first copy stays.
non-empty line ≥ 50 chars repeats within a
SKILL.mdor its command), catchingthis class of copy-paste error going forward.
SKILL.mdand command stay in sync.Validation
npm test→ 55/55 pass (44 prior + 11 new duplicate-blockchecks;
code-review: no duplicated block✔).code-reviewlocally viaopencode runagainst a fixturewith a planted off-by-one bug (
return items[idx + 1]). Both models caught it atconfidence 100 — full responses below.
Model outputs
DeepSeek V4 Flash Free — full finding
GPT-5.5 — full finding