Add design specifics and a self-critique rubric to frontend-design#5
Merged
Conversation
The skill was pure aesthetic prose with no self-review. This adds three sections, reworded from cited sources and kept under 500 lines: - Concrete anti-default moves: font-by-vibe picks, layout archetypes, type contrast, semantic CSS-variable tokens, one orchestrated page-load. - An objective self-critique rubric the model runs before returning (WCAG 2.2 AA contrast/semantics/alt/focus/reflow plus craft checks), framed honestly since models tend to over-praise their own output. - An optional, cross-platform validation note (html-validate static; pa11y or axe for rendered DOM), including an opt-in vision-only Playwright screenshot loop that text-only models skip. Adds tests/frontend-design.test.mjs to guard the additions. The command is regenerated from the skill and stays in sync.
The skill already warned against converging on common choices, but the new font and layout lists risk becoming the next default the way Space Grotesk did. This adds an explicit "vary across generations" rule — treat the lists as seeds to rotate, deliberately diverge when a brief resembles a prior one, and never ship two different products as the same template. A matching self-critique check rejects output that reads as a default pattern or a previous generation. A test guards the rule; the command is regenerated from the skill.
Output of running the rewritten frontend-design skill in OpenCode on a NEBULA sci-fi magazine brief: a dark editorial aesthetic with an acid-green accent, a condensed display face (not Inter/Roboto), and three distinct pricing tiers. Concrete evidence the skill produces distinctive, non-generic UI. Linked from the PR's Validation section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frontend-designwas pure aesthetic prose with no self-review. This adds four things (reworded from cited sources, still < 500 lines):alt, first-rule-of-ARIA, visible focus + keyboard operability, 320px reflow, plus craft checks (type scale,line-height>= 1.5, spacing scale,prefers-reduced-motion). Concrete pass/fail checks, since models over-praise their own work.html-validate(static),pa11y/axe (rendered DOM), and an opt-in, vision-only Playwright screenshot->critique loop (text-only models skip it).tests/frontend-design.test.mjs(5 checks) guards the additions; the command is regenerated from the skill and stays in sync.Validation
npm test-> 60/60 pass (skill-lint + frontend-design content guards). Skill 89 lines / command 91 (< 500); descriptions identical, command inlines the body.Real run —
/frontend-designon a NEBULA sci-fi magazine briefGenerated in OpenCode. The skill produced a distinctive, on-brief UI — a dark editorial aesthetic with an acid-green accent, a condensed display face (not Inter/Roboto), an
ISSUE 001detail card, and three differentiated pricing tiers — i.e. non-generic output, exactly what the rewrite targets.