[feat] add argument to ignore devices #245
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadilshabier
force-pushed
the
ignore-device
branch
from
593d28d to
49fa998
Compare
|
Hi before I review this I notice that no documentation was added. Would you mind documenting the flags you're adding? |
aadilshabier
force-pushed
the
ignore-device
branch
from
49fa998 to
543735f
Compare
|
CC: @zubairmh can you review this PR? |
Shinyzenith
reviewed
Feb 27, 2024
aadilshabier
force-pushed
the
ignore-device
branch
from
543735f to
9fce949
Compare
Shinyzenith
previously approved these changes
Feb 28, 2024
|
I'll wait on zubairs review too, if he doesn't respond by today, I'll merge it. |
aadilshabier
force-pushed
the
ignore-device
branch
2 times, most recently
from
53d85df to
d717211
Compare
|
Hi, I would like to merge this, can you kindly rebase this? My apologies for the delay. |
--ignoredevice takes the same format as --device and ignores the devices listed, separated by semicolon. If a device is listed both in the --device argument and --ignoredevice argument, it is not added. Also replaced default name from "" to "[unknown]" to prevent devices without valid names from being matched by empty device arguments.
aadilshabier
force-pushed
the
ignore-device
branch
from
d717211 to
3cd0d17
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #137
--ignoredevice takes the same format as --device and ignores the devices listed, separated by semicolon. If a device is listed both in the --device argument and --ignoredevice argument, it is not added.