Add database script for MediaWiki 1.43 #882
Conversation
There was a problem hiding this comment.
TODO notes for reviewers:
- Understand Andrew's changes
- Replicate the changes ourselves to see if we get the same result
- Check the changes in config/wbstack.php are correct / no side effects
- Check that it works with new image of mediawiki proposed - in particular, we want to test our changes that are in the
wbstack/mediawikidist-persistdirectory
We've started to look through this, it looks good so far, but still need to complete the steps from above. However, we notice that this PR is contingent on having looked through wbstack/mediawiki#475 as well (which we haven't done thoroughly yet). Should we hold off merging until that is done and then merge both at the same time?
Review assisted by @tarrow and @rosalieper as well
| @@ -62,7 +79,7 @@ cd ./w/extensions/ && ls -dm * | tr -d ' ' | tr -d \\n && cd ./../../ | |||
|
|
|||
| This is an example install command with `WikibaseEdtf` excluded: | |||
| ``` | |||
| WBS_DOMAIN=maint php ./w/maintenance/install.php --dbserver sql-clean --dbuser root --dbpass toor --dbname wiki --extensions AdvancedSearch,Auth_remoteuser,CirrusSearch,Cite,CodeEditor,CodeMirror,ConfirmAccount,ConfirmEdit,DeleteBatch,Echo,Elastica,EmbedVideo,EntitySchema,Gadgets,Graph,InviteSignup,JsonConfig,Kartographer,Mailgun,Math,MobileFrontend,MultimediaViewer,Nuke,OAuth,PageImages,ParserFunctions,Poem,Popups,RevisionSlider,Score,Scribunto,SecureLinkFixer,SpamBlacklist,StopForumSpam,SyntaxHighlight_GeSHi,TemplateData,TemplateSandbox,TextExtracts,Thanks,ThatSrc,TorBlock,TwoColConflict,UniversalLanguageSelector,WikiEditor,WikiHiero,Wikibase,WikibaseCirrusSearch,WikibaseExampleData,WikibaseInWikitext,WikibaseLexeme,WikibaseLexemeCirrusSearch,WikibaseManifest,cldr --pass AdminPass0 SiteName AdminName | |||
| WBS_DOMAIN=maint php ./w/maintenance/install.php --dbserver sql-clean --dbuser root --dbpass toor --dbname wiki --extensions AdvancedSearch,CirrusSearch,Cite,CodeEditor,CodeMirror,ConfirmAccount,ConfirmEdit,DeleteBatch,Echo,Elastica,EmbedVideo,EntitySchema,Gadgets,InviteSignup,JsonConfig,Kartographer,Mailgun,Math,MobileFrontend,MultimediaViewer,Nuke,OAuth,PageImages,ParserFunctions,Poem,RevisionSlider,Score,Scribunto,SecureLinkFixer,SpamBlacklist,StopForumSpam,SyntaxHighlight_GeSHi,TemplateData,TemplateSandbox,TextExtracts,Thanks,ThatSrc,TorBlock,TwoColConflict,UniversalLanguageSelector,VisualEditor,WikiEditor,WikiHiero,Wikibase,WikibaseCirrusSearch,WikibaseInWikitext,WikibaseLexeme,WikibaseLexemeCirrusSearch,WikibaseManifest,cldr --pass AdminPass0 SiteName AdminName | |||
There was a problem hiding this comment.
How come these extensions are removed and added? I think we should probably document the reasoning somewhere ™️ for future reference.
There was a problem hiding this comment.
We have separate commits for extensions that are added or removed.
wbstack/mediawiki#453 - remove Graph
wbstack/mediawiki#367 - remove Popups
wbstack/mediawiki#455 - add VisualEditor
wbstack/mediawiki@e2e48b8 - remove WikibaseExampleData and Auth_remoteuser
|
In order to test this you'll need to either resolve T387115 or use one of the workarounds listed there |
There was a problem hiding this comment.
I reproduced the steps and it all looks good to me. there were same new changes to the sql while reproducing these steps and here is the PR for them #968
|
Thanks for reviewing this @rosalieper!
I think it would be a good idea to include those changes in this PR. This is the standard problem of two bits of work done on the repo at the same time, resulting in one PR having to pull in the changes caused by the other. I also see there are merge conflicts that need to be resolved due to the new changes. |
Comparison of
mw1.39-wbs1andmw1.43-wbs1:https://www.diffchecker.com/rEJeYiDD/