Skip to content

add scheduler safeguard #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add scheduler safeguard #917

wants to merge 1 commit into from

Conversation

deer-wmde
Copy link
Contributor

alternative or addition to #916

@deer-wmde deer-wmde mentioned this pull request Apr 16, 2025
@deer-wmde deer-wmde marked this pull request as draft April 16, 2025 13:46
@tarrow
Copy link
Contributor

tarrow commented Apr 16, 2025

Did you already try this locally and confirm fewer jobs are fired?

@tarrow
Copy link
Contributor

tarrow commented Apr 24, 2025

From my rough inspection of how scheduling tasks is supposed to work I think this is unnecessary and I would expect tasks from Kernel.php to only be scheduled by our scheduler pod.

Specifically I am looking at

api/start.sh

Line 26 in e629b07

elif [ "$role" = "scheduler" ]; then
which appears to me to only schedule tasks on the scheduler pod anyway.

Therefore I think we should try #916 first in preference to this

@deer-wmde
Copy link
Contributor Author

From my rough inspection of how scheduling tasks is supposed to work I think this is unnecessary and I would expect tasks from Kernel.php to only be scheduled by our scheduler pod.

Specifically I am looking at

api/start.sh

Line 26 in e629b07

elif [ "$role" = "scheduler" ]; then

which appears to me to only schedule tasks on the scheduler pod anyway.

Therefore I think we should try #916 first in preference to this

ah! I think I missed this part.

@deer-wmde deer-wmde closed this Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants